DLPX-84042 Upgrade sshj to latest version (plus Raul's mods) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenkatanadhanG
force-pushed
the
dlpx/pr/venkatanadhang/ecd6abe8-2e98-4107-9420-95ea1558366f
branch
2 times, most recently
from
53a5893 to
7153dc7
Compare
VenkatanadhanG
changed the title
VenkatanadhanG
force-pushed
the
dlpx/pr/venkatanadhang/ecd6abe8-2e98-4107-9420-95ea1558366f
branch
from
7153dc7 to
384e549
Compare
VenkatanadhanG
requested review from
ShibasishDelphix,
brad-lewis,
dbshah12,
derek-woodham-delphix,
ljiang-delphix,
nealquigley,
rasantel,
sebroy,
skinner-m-c and
smeda-delphix
smeda-delphix
approved these changes
Feb 2, 2023
derek-woodham-delphix
approved these changes
Feb 2, 2023
Author
|
http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/4375/ failed where 'test_pre_upgrade_min_version' testcase is failed, not related to this PR |
rasantel
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updating sshj with custom changes.
Solution
Clean cherry-pick of #4 on top of the latest release, 0.35.0.
Published on artifactory as version 0.35.0-dlpx73623.
App-gate review : https://github.com/delphix/dlpx-app-gate/pull/90
Testing Done
Running git ab-pre-push with this version of sshj: : (Failure not related to this PR)
http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/4375/
Running git dx-test with this version of sshj:
http://selfservice.jenkins.delphix.com/job/dx-integration-tests/6412/