DLPX-83302 [Backport of DLPX-73623 to 6.0.17.0] SSHJ remote port forwarding buffers can grow without limits #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arding buffers can grow without limits
smeda-delphix
requested review from
brad-lewis,
derek-woodham-delphix,
ljiang-delphix,
rasantel and
skinner-m-c
derek-woodham-delphix
approved these changes
Oct 17, 2022
brad-lewis
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost clean cherry-pick of #3 on top of the latest release, 0.34.0. The only change is to Ignore the test case -
RemotePFPerformanceTestas it uses a deprecated methodsetHeartbeatIntervaland replacing that with Keep alive still didn't work as the test is expecting port set up on the local machine to pass.Published on artifactory as version 0.34.0-dlpx73623 and running a trunk engine ab-pre-push including upgrade and precommit tests with this version of sshj: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/3508/