generated from delphix/.github
-
Notifications
You must be signed in to change notification settings - Fork 11
DLPX-87710 upgrade from 6.0.16.0 to 15.0.0.0 failed because disk quota error #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
palash-gandhi
merged 1 commit into
develop
from
dlpx/pr/palash-delphix/b05fe51f-2044-49b0-987c-7bda70123c08
Sep 7, 2023
Merged
DLPX-87710 upgrade from 6.0.16.0 to 15.0.0.0 failed because disk quota error #46
palash-gandhi
merged 1 commit into
develop
from
dlpx/pr/palash-delphix/b05fe51f-2044-49b0-987c-7bda70123c08
Sep 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ac3d98
to
22c47af
Compare
palash-gandhi
added a commit
that referenced
this pull request
Sep 1, 2023
22c47af
to
d3761c7
Compare
palash-gandhi
added a commit
that referenced
this pull request
Sep 1, 2023
d3761c7
to
d0986b1
Compare
prakashsurya
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. pending verification.
6e87f48
to
74bc4bf
Compare
palash-gandhi
added a commit
that referenced
this pull request
Sep 4, 2023
d0986b1
to
3b76d51
Compare
sumedhbala-delphix
approved these changes
Sep 5, 2023
This was referenced Sep 5, 2023
palash-gandhi
added a commit
that referenced
this pull request
Sep 6, 2023
3b76d51
to
908ae86
Compare
908ae86
to
18c0a36
Compare
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The upgrade image on
develop
is approximately 11G, up from ~6.5G onrelease
. This was because the size of the kernel debug symbols have doubled in the past few days. The config through which kernel modules that should be excluded seems to be ignored.Upstream has moved to a new "annotations" model to manage kernel configs. See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2019000 for more information which is probably why the old style config is ignored.
Solution
Migrate to the new annotations model using the scripts that upstream provides. It seems like that the build runs checks on the annotations file and expects it to be a complete list of ALL annotations. In doing so, we had 2 options:
delphix_annotations
that contains ALL annotations.delphix_annotations
that contains only annotations that we would like to exclude. But this will fail the config checks. The checks do not offer anything more and a smallerdelphix_annotations
file is what we prefer. We have also done this here: DLPX-83442 Disable various kernel modules which we don't use #20We chose option 2. As such, skip the config-checks via delphix/linux-pkg#299
Testing Done
develop
,release
and an engine running my bits.develop
had a lot more kernel modules thanrelease
.An engine running my bits had fewer kernel modules than the current
develop
.An engine running my bits had few differences as compared to the current
release
.Notes to Reviewers
Here are some engines if you would like to test some of this yourselves:
stock
develop
without my fix: pg-kernel-modules-develop.dlpxdc.corelease
: pg-kernel-modules-release.dlpxdc.coEngine with my bits: pg-kernel-annotations.dlpxdc.co