Skip to content

DLPX-87710 upgrade from 6.0.16.0 to 15.0.0.0 failed because disk quota error #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

palash-gandhi
Copy link
Contributor

@palash-gandhi palash-gandhi commented Aug 31, 2023

Problem

The upgrade image on develop is approximately 11G, up from ~6.5G on release. This was because the size of the kernel debug symbols have doubled in the past few days. The config through which kernel modules that should be excluded seems to be ignored.
Upstream has moved to a new "annotations" model to manage kernel configs. See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2019000 for more information which is probably why the old style config is ignored.

Solution

Migrate to the new annotations model using the scripts that upstream provides. It seems like that the build runs checks on the annotations file and expects it to be a complete list of ALL annotations. In doing so, we had 2 options:

  1. Create a new delphix_annotations that contains ALL annotations.
  2. Create a new delphix_annotations that contains only annotations that we would like to exclude. But this will fail the config checks. The checks do not offer anything more and a smaller delphix_annotations file is what we prefer. We have also done this here: DLPX-83442 Disable various kernel modules which we don't use #20

We chose option 2. As such, skip the config-checks via delphix/linux-pkg#299

Testing Done

delphix@pg-ntp:~$ aws s3 ls s3://dev-de-images/builds/jenkins-selfservice/appliance-build/develop/pre-push/1397/upgrade-artifacts/internal-qa.upgrade.tar
2023-09-06 06:25:27 4975216640 internal-qa.upgrade.tar
  • Compared the list of kernel modules on develop, release and an engine running my bits.

develop had a lot more kernel modules than release.

Screenshot 2023-08-31 at 8 19 05 AM



An engine running my bits had fewer kernel modules than the current develop.

Screenshot 2023-09-01 at 9 23 21 PM



An engine running my bits had few differences as compared to the current release.

Screenshot 2023-09-01 at 9 21 25 PM

Notes to Reviewers

Here are some engines if you would like to test some of this yourselves:
stock develop without my fix: pg-kernel-modules-develop.dlpxdc.co
release: pg-kernel-modules-release.dlpxdc.co
Engine with my bits: pg-kernel-annotations.dlpxdc.co

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/b05fe51f-2044-49b0-987c-7bda70123c08 branch from 6ac3d98 to 22c47af Compare August 31, 2023 14:54
@palash-gandhi palash-gandhi marked this pull request as ready for review August 31, 2023 15:26
palash-gandhi added a commit that referenced this pull request Sep 1, 2023
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/b05fe51f-2044-49b0-987c-7bda70123c08 branch from 22c47af to d3761c7 Compare September 1, 2023 17:16
palash-gandhi added a commit that referenced this pull request Sep 1, 2023
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/b05fe51f-2044-49b0-987c-7bda70123c08 branch from d3761c7 to d0986b1 Compare September 1, 2023 19:59
Copy link

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. pending verification.

palash-gandhi added a commit that referenced this pull request Sep 4, 2023
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/b05fe51f-2044-49b0-987c-7bda70123c08 branch from d0986b1 to 3b76d51 Compare September 4, 2023 20:12
delphix-devops-bot pushed a commit that referenced this pull request Aug 15, 2024
delphix-devops-bot pushed a commit that referenced this pull request Aug 22, 2024
delphix-devops-bot pushed a commit that referenced this pull request Aug 23, 2024
prakashsurya pushed a commit that referenced this pull request Sep 23, 2024
delphix-devops-bot pushed a commit that referenced this pull request Oct 20, 2024
delphix-devops-bot pushed a commit that referenced this pull request Oct 21, 2024
palash-gandhi added a commit that referenced this pull request Oct 24, 2024
delphix-devops-bot pushed a commit that referenced this pull request Nov 10, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 18, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 19, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 20, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 21, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 22, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 23, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 24, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 25, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 26, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 27, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 28, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 29, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 30, 2024
delphix-devops-bot pushed a commit that referenced this pull request Dec 31, 2024
delphix-devops-bot pushed a commit that referenced this pull request Jan 1, 2025
delphix-devops-bot pushed a commit that referenced this pull request Jan 2, 2025
delphix-devops-bot pushed a commit that referenced this pull request Jan 3, 2025
delphix-devops-bot pushed a commit that referenced this pull request Jan 4, 2025
delphix-devops-bot pushed a commit that referenced this pull request Jan 5, 2025
delphix-devops-bot pushed a commit that referenced this pull request Jan 7, 2025
delphix-devops-bot pushed a commit that referenced this pull request Feb 12, 2025
delphix-devops-bot pushed a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants