Skip to content

DLPX-87759 Skip config checks while building the kernel #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

palash-gandhi
Copy link
Contributor

@palash-gandhi palash-gandhi commented Sep 1, 2023

Problem

This is a dependent change required for delphix/linux-kernel-aws#46. Please see the problem statement in that PR for context.

Solution

Pass an option to skip the config checks to updateconfigs.

Testing Done

[Fri Sep 01, 12:41:49] ~/git/linux-pkg (develop)
 $ git ab-pre-push -b linux-kernel-aws
Running `git push -f origin c8dad4b3b19c5426f860d997acd033222c7c4305:refs/heads/dlpx/test/___develop___/pgandhi-delphix/c8dad4b3b19c5426f860d997acd033222c7c4305`
Your build is at: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/6892/

From this build:

 Running: fakeroot debian/rules updateconfigs skipdbg=false uefi_signed=false disable_d_i=true do_zfs=false do_dkms_nvidia=false do_dkms_nvidia_server=false do_dkms_vbox=false do_dkms_wireguard=false flavours=aws abinum=1041-dx2023090119-6e87f48dd do_skip_checks=true
 dh_testdir;
...
...
 Skipping config-check (skip_checks=true) ...
 
 Importing all configurations ...
 
 * Import configs for amd64-aws ...

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4 branch from 186f071 to c8dad4b Compare September 1, 2023 19:36
Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending passing tests.. lets also verify this works with the updated kernel changes you're working on too, before landing..

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4 branch from c8dad4b to 8c318ef Compare September 1, 2023 20:09
@palash-gandhi palash-gandhi changed the title Skip config checks while building the kernel DLPX-87759 Skip config checks while building the kernel Sep 1, 2023
@palash-gandhi palash-gandhi marked this pull request as ready for review September 1, 2023 21:05
@palash-gandhi
Copy link
Contributor Author

LGTM pending passing tests.. lets also verify this works with the updated kernel changes you're working on too, before landing..

Thanks, my tests on the other change also passed. http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/6891/

delphix@pg-release:~$ ls -alh internal-qa.upgrade.tar
-rw-r--r-- 1 delphix staff 6.1G Sep  2 01:35 internal-qa.upgrade.tar

@palash-gandhi palash-gandhi requested a review from sebroy September 2, 2023 04:34
@palash-gandhi palash-gandhi enabled auto-merge (squash) September 2, 2023 04:35
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4 branch from 8c318ef to a2cb8d0 Compare September 2, 2023 04:36
@palash-gandhi palash-gandhi merged commit 961cad7 into develop Sep 5, 2023
@palash-gandhi palash-gandhi deleted the dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4 branch September 5, 2023 13:51
jwk404 added a commit to jwk404/linux-pkg that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants