Move open-iscsi override out of /etc #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsurya
approved these changes
Jan 27, 2021
pzakha
added a commit
to pzakha/delphix-platform
that referenced
this pull request
Aug 2, 2021
This backports the following changes: - Move open-iscsi override out of /etc (delphix#263) - changes for docker dep (delphix#311) (which is part of DLPX-76534) - Replace TravisCI with Github Actions (delphix#212) - Use "delphix/actions" for shellcheck and shfmt (delphix#220) Note that this also adds the following file from master: - .github/workflows/main.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want the new
open-iscsi.service.d/override.conffile (from #262) to reside under/libnot/etcSee PR #249 -- Move various configuration files out of "/etc"
Testing
ab-pre-push
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4670/
Confirmed that the override file now lives under
/lib/systemd/system/Confirmed that
systemctl cat open-iscsicontains the override content