Replace TravisCI with Github Actions #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsurya
changed the title
prakashsurya
force-pushed
the
use-actions
branch
from
2215fd5 to
2899b67
Compare
sdimitro
approved these changes
Mar 26, 2020
|
I don't have a lot of experience with github actions, but this looks reasonable to me. One small suggestion I have is to reword the name of the PR - as it is it's a little unclear if we're moving to or from TravisCI. Maybe: "Replace TravisCI with Github Actions" or "Leverage Github Actions instead of TravisCI" |
This change adds the necessary files and logic to take advantage of
GitHub Actions for running our automated tests. Currently we rely on
TravisCI to do this, but we'd like to transition over to GitHub Actions,
for the following reasons:
1. The Actions UI is more integrated with GitHub PRs
2. Best practices at Delphix suggests using Actions
Additionally, this change removes integration with the "bors" bot.
prakashsurya
force-pushed
the
use-actions
branch
from
2899b67 to
d0d29a5
Compare
prakashsurya
changed the title
Done! |
pzakha
added a commit
to pzakha/delphix-platform
that referenced
this pull request
Aug 2, 2021
This backports the following changes: - Move open-iscsi override out of /etc (delphix#263) - changes for docker dep (delphix#311) (which is part of DLPX-76534) - Replace TravisCI with Github Actions (delphix#212) - Use "delphix/actions" for shellcheck and shfmt (delphix#220) Note that this also adds the following file from master: - .github/workflows/main.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the necessary files and logic to take advantage of
GitHub Actions for running our automated tests. Currently we rely on
TravisCI to do this, but we'd like to transition over to GitHub Actions,
for the following reasons:
Additionally, this change removes integration with the "bors" bot.