Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #348

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Update actions #348

merged 6 commits into from
Nov 6, 2024

Conversation

shaynafinocchiaro
Copy link
Contributor

Description

PR to remove unit test action and consolidate into one.
Action requires 2 repository variables: CODE_COVERAGE_TARGET, CODE_COVERAGE_DIR

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

hoppea2
hoppea2 previously approved these changes Nov 5, 2024
mjsdell
mjsdell previously approved these changes Nov 5, 2024
Copy link
Collaborator

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tdawe
tdawe previously approved these changes Nov 5, 2024
@shaynafinocchiaro shaynafinocchiaro merged commit e9a00c0 into main Nov 6, 2024
5 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the update-actions branch November 6, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants