Swapped to Permissions protocol records for permission grant authorization #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
mistermoe,
csuwildcat and
LiranCohen
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
- Coverage 98.62% 98.57% -0.05%
==========================================
Files 76 71 -5
Lines 10765 10406 -359
Branches 1555 1517 -38
==========================================
- Hits 10617 10258 -359
Misses 142 142
Partials 6 6 ☔ View full report in Codecov by Sentry. |
thehenrytsai
commented
Apr 1, 2024
LiranCohen
reviewed
Apr 9, 2024
LiranCohen
reviewed
Apr 9, 2024
LiranCohen
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a LOT of remaining naming inconsistencies due to this change which I will address in a subsequent PR as a final clean up. I can roll all of them into this PR if preferred, but it will be at least 100s more lines of noise scattered throughout the change.