-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags
functionality to Records
.
#706
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 98.46% 98.48% +0.01%
==========================================
Files 74 74
Lines 10195 10329 +134
Branches 1511 1533 +22
==========================================
+ Hits 10039 10173 +134
Misses 150 150
Partials 6 6 ☔ View full report in Codecov by Sentry. |
tags
functionality to Records
.tags
functionality to Records
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐 🐐 🐐 ! Thanks for adding this powerful feature. This alone will take dev-ex to the next level!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐 🐐 🐐 🚀 🚀 🚀
83a34e6
to
ff3aed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 once more!
Implement indexing for the work in: decentralized-identity/dwn-sdk-js#706 - Adds reference tables: - messageStoreRecordsTags - eventLogRecordsTags - Adds helper methods to deal with adding foreign key constraints to all 3 dialects. - Adds helper methods to deal with returning `insertedId` across all 3 dialects. --------- Co-authored-by: Henry Tsai <henrytsai@outlook.com>
This is a first pass at adding the functionality for
tags
within records as mentioned here #642.There will be subsequent PRs for any protocol specific enforcement.
Filtering
A filter for a tag is treated as an Equal filter. If any of the values within the tag array match the filter, the record matches.
Exact Match
Range Filters
Prefix Filters