Skip to content

fix: sdk local scene dev hot-reload #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Mar 19, 2025

WHY

Hot-reload is not working beyond the 1st reload.

WHAT

Removed unneeded CacheCleaner usage that randomly breaks hot-reload. (introduced recently at #3595)

TEST INSTRUCTIONS (hot-reload)

  1. Download this test scene
  2. Enter the scene root folder and run npm i and then npm run start -- --explorer-alpha
  3. Close the Explorer that auto-opened. Leave the scene running in the console/terminal.
  4. Download the build from this PR and connect it to the running scene using the console command according to your OS
  5. Once the scene loads, leave the Explorer running and in any text editor open the index.ts file of the scene that you have running
  6. Modify any Vector3 value (for example change Vector3.create(32, 0, 32) to Vector3.create(15, 0, 15)), save the file and confirm that the scene gets automatically re-loaded in the Explorer that you left running in the previous step
  7. After the automatic reload finishes, repeat step 6 several more times to make sure hot-reload keeps working beyond the first one

@pravusjif pravusjif added bug Something isn't working 0-critical Highly important issues that should be prioritised sdk labels Mar 19, 2025
@pravusjif pravusjif self-assigned this Mar 19, 2025
Copy link
Contributor

github-actions bot commented Mar 19, 2025

@pravusjif pravusjif marked this pull request as ready for review March 19, 2025 17:34
@pravusjif pravusjif requested review from a team as code owners March 19, 2025 17:34
@pravusjif pravusjif requested review from anicalbano and removed request for a team and Ludmilafantaniella March 19, 2025 17:34
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Explorer Alpha Mar 19, 2025
@pravusjif pravusjif removed request for dalkia and lorux0 March 19, 2025 17:42
@pravusjif pravusjif moved this from Todo to QA in Creators Tools Mar 19, 2025
@pravusjif pravusjif moved this from In Progress to With QA / Awaiting Review in Explorer Alpha Mar 19, 2025
@pravusjif pravusjif enabled auto-merge (squash) March 19, 2025 21:24
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed by QA and working as expected! 😄

19.03.2025_18.23.56_REC.mp4

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Mar 19, 2025
@pravusjif pravusjif merged commit d0f24a1 into dev Mar 19, 2025
14 of 18 checks passed
@pravusjif pravusjif deleted the fix/sdk-local-scene-dev-hot-reload branch March 19, 2025 21:30
@github-project-automation github-project-automation bot moved this from In Progress to Done in Explorer Alpha Mar 19, 2025
@github-project-automation github-project-automation bot moved this from QA to Done in Creators Tools Mar 19, 2025
pravusjif added a commit that referenced this pull request Mar 19, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-critical Highly important issues that should be prioritised bug Something isn't working sdk
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants