-
Notifications
You must be signed in to change notification settings - Fork 13
fix: local scene dev reload memory leak #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ner call on LSD scene reload
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
…ecentraland/unity-explorer into fix/local-scene-dev-reload-memory-leak
|
With 0eba597 commit I clean up the leaked materials on LSD reload:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup 👍
…/local-scene-dev-reload-memory-leak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ PR reviewed and approved by QA. Didn't find any issues while reloading the scenes and the memory remained stable with no significant increments.
17.03.2025_08.53.26_REC.mp4
|
Sorry Ani, can you re-check with this other scene? I just updated the original description, my bad =S |
|
@pravusjif all good with that scene too! 17.03.2025_09.35.29_REC.mp4 |







WHY
During Local Sccene Development mode, RAW GLTFs are being used instead of asset bundles. With every SDK scene code change or file change, the scene gets automatically reloaded (known as "hot-reload")
It has been detected that GLTF textures are not being disposed at all when the scene is reloading, infinitely accumulating in memory, potentially making the app crash or the hot reload unreliable
Issue: decentraland/creator-hub#271
WHAT
TEST INSTRUCTIONS
npm iand thennpm run start -- --explorer-alphaNote: It's OK if you see the chat message saying "Error running command." that's an unrelated (inoffensive) problem
VIDEO COMPARISON DEMO
PROD:
After 11 scene reloads (without changing anything on the scene) the memory is almost doubled.
LSD-memory-lead-PROD.mp4
THIS PR:
After 11 scene reloads (without changing anything on the scene) the memory is kept pretty stable, only increasing a total of about 300~ MBs and never surpassing that.
LSD-memory-lead-FIX.mp4