-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slate Editor Crashing semi randomly #7152
Comments
Maybe it's the decap-cms/packages/decap-cms-widget-markdown/src/MarkdownControl/renderers.js Lines 207 to 209 in 6266ccc
children as described in ianstormtaylor/slate#3930
Might need to do something like
|
I tested it out by changing div.as.br.tag.mp4I think all the components in https://github.com/decaporg/decap-cms/blob/6266ccc16a8a992695d4bdf13a63746986cedc3e/packages/decap-cms-widget-markdown/src/MarkdownControl/renderers.js might need to render out {props.children} for slate to not throw when nodes get deleted. |
* Potential Fix for #7152 * fix: update e2e tests for soft breaks --------- Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
* Potential Fix for #7152 * fix: update e2e tests for soft breaks --------- Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
In 3.2.1 the lose of focus after backspacing from multiple shift+return's should also be fixed, do you mind testing again? |
Describe the bug
Slate editor crashes randomly with
Error: Cannot resolve a DOM node from Slate node: {"text":""}
I've managed to track this down and reproduce it on https://demo.decapcms.org/#/collections/posts/entries/2024-03-20-post-number-20
To Reproduce
editor.crashing.mp4
Expected behavior
No crashes
Related
This was the only reference I could find for this error ianstormtaylor/slate#3930 but I'm unclear on how to resolve.
The text was updated successfully, but these errors were encountered: