-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting a bullet point in rich text editor crashes CMS #7123
Comments
I am also hitting this error. Hopefully I can provide some additional details that will help. Crash log
This is currently running on ocalhost, but the crash is occurring on my live site as well. To reproduce
Images |
Potentially related to #7152 |
I have not been able to reproduce this since upgrading to 3.1.10, have you, @nathancatania ? |
@LHSnow I'm able to consistently reproduce this on 3.1.10. |
Can reproduce also on 3.1.10. |
this should be fixed in version 3.2.1, @mohab-sameh or @nathancatania do you mind testing it out to confirm? did not address the other bug at this time (the one that keeps the link when enter-ing to new bullet) |
@demshy sure thing. I'll test and report back. Please let me know when you address that one as well and I'll help with testing. |
@demshy sorry for the very late response. I'm still able to reproduce this bug. When I delete a bullet point that has a hyperlink, it crashes just like before. |
I'm unable to reproduce the bug in the latest Decap in either Firefox or Brave. |
Describe the bug
When editing main content using the rich text editor (markdown widget), deleting a bullet point causes the editor to crash and replace the entire CMS with an error page.
The console reports
Uncaught Error: Cannot find a descendant at path [3,0,1] in node
(or whatever the nested xpath position of the bullet point was, I am assuming).The page contains the entire text in json format and after that in markdown, for ease of keeping unsaved edits for later (nice!).
To Reproduce
Expected behavior
Bullet point should disappear and the caret should stay on an empty line
Applicable Versions:
CMS configuration
Additional
This error does not occur in the demo Slate editor, but does nothing when hitting backspace, a behavior which is also unintuitive, i.e. having to klick on the bullet point button to delete the empty point. Would it go away with a dependency update or is the bug caused by Decap? I did notice at Discord that we are moving towards Plate instead, but is there a dependency update that could be done in the meantime. I'd rather have a somewhat unintuitive behavior than a broken one.
The text was updated successfully, but these errors were encountered: