Add flags to identify and stub Mesos requests #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo has @mesosphere-mergebot integration. You can interact with the following commands. |
orlandohohmeier
force-pushed
the
orlandohohmeier/fix/adjust-mesos-request-stubs
branch
from
8a7958b
to
2b829dc
Compare
|
Alfred test this please |
|
@orlandohohmeier could you please rebase this one? |
added 2 commits
January 2, 2018 13:29
Add flags (query parameters) to identify and stub Mesos Operator API requests to fix the integration tests that were otherwise failing or flaky due to parsing errors in the `MesosStateStore`. The store failed to parse the `GET_MASTER` response as we could only register one stub for both the `GET_MASTER` and `SUBSCRIBE` requests resulting in JSON parse errors due to the different response formats (RecoredIO<JSON>, JSON). The flags are necessary as Cypress can only stub requests based on the URL and request method and doesn't provide the means to dynamically stub requests based on the payload as documented in cypress-io/cypress#521. We will remove the flags once the Cypress team rewrote the network handling and added support for dynamic stubs as documented in cypress-io/cypress#687 or we've addressed https://jira.mesosphere.com/browse/DCOS_OSS-2021.
Remove the test delay used to fix the "Cannot Connect With The Server" problem as the underlying issue is fixed by the introduction of separate stubs for the Mesos `SUBSCRIBE` and `GET_MASTER` request.
orlandohohmeier
force-pushed
the
orlandohohmeier/fix/adjust-mesos-request-stubs
branch
from
2b829dc
to
ebb9008
Compare
Poltergeist
approved these changes
Jan 2, 2018
nLight
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ This PR includes changes that are going to be introduced with #2592. For a list of changes please see: orlandohohmeier/fix/add-missing-framework-mocks...orlandohohmeier/fix/adjust-mesos-request-stubs
Add flags (query parameters) to identify and stub Mesos Operator API requests to fix the integration tests that were otherwise failing or flaky due to parsing errors in the
MesosStateStore. The store failed to parse theGET_MASTERresponse as we could only register one stub for both theGET_MASTERandSUBSCRIBErequests resulting in JSON parse errors due to the different response formats (RecoredIO, JSON).The flags are necessary as Cypress can only stub requests based on the URL and request method and doesn't provide the means to dynamically stub requests based on the payload as documented in cypress-io/cypress#521. We will remove the flags once the Cypress team rewrote the network handling and added support for dynamic stubs as documented in cypress-io/cypress#687 or we've addressed https://jira.mesosphere.com/browse/DCOS_OSS-2021.