Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @dcos/mesos-client 0.1.9 #2571

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Conversation

nLight
Copy link
Contributor

@nLight nLight commented Dec 14, 2017


✅ This PR depends on changes that are going to be introduced with #2593. For a list of changes please see: orlandohohmeier/fix/adjust-mesos-request-stubs...drozhkov/mesos-client-0.1.9


We thought we've resolved the issue, but that time bundle distribution messed up thus the old version persisted in the dist folder. With this bump I reassured that the updates went through.

Closes DCOS-19946

@d2iq-mergebot
Copy link

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot test  
@mesosphere-mergebot ship-it  
@mesosphere-mergebot integrate  

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

juliangieseke
juliangieseke previously approved these changes Dec 14, 2017
@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

Poltergeist
Poltergeist previously approved these changes Dec 14, 2017
Copy link
Contributor

@Poltergeist Poltergeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 feel free to merge once tests pass :trollface:

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

7 similar comments
@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 14, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 15, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 15, 2017

Fail consistently on Jenkins

navigates to health tab [0fc].Node Health Tab [0fa] Navigate to tab [0fb] navigates to health tab [0fc]
"before each" hook for "filters by health [0fe]".Node Health Tab [0fa] Health Tab [0fd] "before each" hook for "filters by health [0fe]"
navigates to node detail page.Nodes Detail Page Navigate to node detail page navigates to node detail page
shows the contents of the Mesos sandbox.Tasks Table Task row Files tab shows the contents of the Mesos sandbox
"before each" hook for "correctly shows health".Tasks Table For a Service Running task without healthcheck "before each" hook for "correctly shows health"

But locally they pass

  (Tests Finished)

  - Tests:           341
  - Passes:          331
  - Failures:        0
  - Pending:         10
  - Duration:        14 minutes, 51 seconds
  - Screenshots:     0
  - Video Recorded:  true
  - Cypress Version: 0.19.1

@nLight
Copy link
Contributor Author

nLight commented Dec 15, 2017

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Dec 15, 2017

Alfred test this

2 similar comments
@nLight
Copy link
Contributor Author

nLight commented Dec 15, 2017

Alfred test this

@ahoskins
Copy link
Contributor

Alfred test this

@bstavroulakis
Copy link
Contributor

bstavroulakis commented Dec 20, 2017

Note: I made a commit to retrieve the expected data from the mesos master that fixed the tests.
But I notice that there is a WIP commit from @nLight which probably has to get fixed first and we'll have to amend my commit since that should solve the issue that occurred.

@nLight
Copy link
Contributor Author

nLight commented Jan 2, 2018

Rebased & lifted the hold merge label

@nLight
Copy link
Contributor Author

nLight commented Jan 2, 2018

Alfred test this

2 similar comments
@nLight
Copy link
Contributor Author

nLight commented Jan 3, 2018

Alfred test this

@nLight
Copy link
Contributor Author

nLight commented Jan 3, 2018

Alfred test this

Copy link
Contributor

@juliangieseke juliangieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@orlandohohmeier
Copy link
Contributor

🚢

@orlandohohmeier orlandohohmeier merged commit 768bbc0 into master Jan 3, 2018
@orlandohohmeier orlandohohmeier deleted the drozhkov/mesos-client-0.1.9 branch January 3, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants