Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example migration of Android application from Java to Kotlin - DO NOT MERGE #9

Open
wants to merge 4 commits into
base: java
Choose a base branch
from
Open

Example migration of Android application from Java to Kotlin - DO NOT MERGE #9

wants to merge 4 commits into from

Commits on Nov 3, 2017

  1. Migrated project to Kotlin, solved issues: 

    - Java protected (package-private + inheritance) != Koltin protected (private + inheritance)
- there is no package private scope to hide classes inside of package and expose just a public interface
- removed logic and tests that verifies nulls
- nullable view has to be guarded with .?, because smart cast does't work for var-s
- builders replaced with data classes
- Mockito fails on closed classes, fixed by Mock Maker
- Mockito any() doesn't work in Kotlin, used alternative from mockito-kotlin
- when is a keyword in Kotlin
- replaced annotationProcessor with kapt
    @dbacinski
    dbacinski committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    347673c View commit details
    Browse the repository at this point in the history

  2. updated circle ci config with latest build tools

    @dbacinski
    dbacinski committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    6ad3d34 View commit details
    Browse the repository at this point in the history

  3. fixed lint error - ime action id

    @dbacinski
    dbacinski committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    f1d19b4 View commit details
    Browse the repository at this point in the history

  4. fixed artifact path

    @dbacinski
    dbacinski committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    21b838c View commit details
    Browse the repository at this point in the history