Example migration of Android application from Java to Kotlin - DO NOT MERGE #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Java protected (package-private + inheritance) != Koltin protected (private + inheritance) - there is no package private scope to hide classes inside of package and expose just a public interface - removed logic and tests that verifies nulls - nullable view has to be guarded with .?, because smart cast does't work for var-s - builders replaced with data classes - Mockito fails on closed classes, fixed by Mock Maker - Mockito any() doesn't work in Kotlin, used alternative from mockito-kotlin - when is a keyword in Kotlin - replaced annotationProcessor with kapt
dbacinski
changed the title
dbacinski
changed the title
dbacinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration findings and solved issues:
protected(package-private + inheritance) != Koltinprotected(private + inheritance)package-privatescope to hide classes inside of package and expose just a public interface.?, because smart cast does't work forvar-sany()doesn't work for objects in Kotlin, alternativeany()from mockito-kotlin can be usedwhenis a keyword in Kotlin, useBDDMockito.given()insteadannotationProcessoris replaced bykaptCheck Files changed tab to see files diff.