Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/02-e2e-showcases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ jobs:
# We test everything for patternhub and main branch
- name: 👩‍🔬 Test showcase with Playwright 🎭
shell: bash
if: github.event.pull_request == null
# TODO: we need to find a more stable solution / https://github.com/db-ux-design-system/core-web/issues/4910
# if: github.event.pull_request == null
env:
NEXT_PUBLIC_BASE_PATH: ${{ inputs.path }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/scripts/post-build/components.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export const getComponents = (): Component[] => [
from: 'ngAfterViewInit() {',
to:
'ngAfterViewInit() {\n' +
'\t this.writeValue(this.value());'
' this.writeValue(this.value() ?? "");'
}
],
react: [
Expand Down
5 changes: 1 addition & 4 deletions packages/components/src/components/select/select.lite.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,7 @@ export default function DBSelect(props: DBSelectProps) {
aria-describedby={props.ariaDescribedBy ?? state._descByIds}>
{/* Empty option for floating label */}
<Show when={props.variant === 'floating' || props.placeholder}>
<option
class="placeholder"
value=""
selected={!props.value}></option>
<option class="placeholder" value=""></option>
</Show>
<Show when={props.options?.length} else={props.children}>
<For each={props.options}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
[disabled]="exampleProps?.disabled"
[icon]="exampleProps?.icon"
[required]="exampleProps?.required"
[value]="exampleProps?.value || ''"
[value]="exampleProps?.value"
[message]="exampleProps?.message"
[showMessage]="exampleProps?.showMessage"
[invalidMessage]="exampleProps?.invalidMessage"
Expand Down
Loading