-
Notifications
You must be signed in to change notification settings - Fork 13
fix(tests): preventing test failure slip-througs to main #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): preventing test failure slip-througs to main #4908
Conversation
The [checks for a PR](https://github.com/db-ux-design-system/core-web/actions/runs/17416146706/job/49445191771?pr=4904) run through smoothly, but it's results would lead to a [fail on `main` branch](https://github.com/db-ux-design-system/core-web/actions/runs/17421313490/job/49460006681). We need to prevent this to happen.
|
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-tests-preventing-test-failure-slipthrougs-to-main |
This reverts commit 8ff0b44.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses test failures that were passing in PR checks but failing on the main branch due to inconsistent test conditions between PR and main branch workflows. The changes fix select component value handling and temporarily disable conditional test execution to prevent false positives.
Key changes:
- Fixed select component value handling by removing fallback empty string assignments
- Temporarily disabled conditional test execution that was causing inconsistent results between PR and main branch
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| showcases/angular-showcase/src/app/components/select/select.component.html | Removed fallback empty string for select value binding |
| packages/components/src/components/select/select.lite.tsx | Removed selected attribute logic from placeholder option |
| packages/components/scripts/post-build/components.ts | Added null coalescing operator for value handling in Angular implementation |
| .github/workflows/02-e2e-showcases.yml | Commented out conditional test execution to ensure consistent test runs |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Proposed changes
The checks for a PR run through smoothly, but it's results would lead to a fail on
mainbranch. We need to prevent this to happen. This is related to the optimizations that we made with PR #4452Types of changes
Further comments