Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Sep 3, 2025

Proposed changes

The checks for a PR run through smoothly, but it's results would lead to a fail on main branch. We need to prevent this to happen. This is related to the optimizations that we made with PR #4452

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

⚠️ No Changeset found

Latest commit: 81221eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Sep 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Sep 3, 2025
@mfranzke mfranzke added 🧪test Improvements/bugs for testing-framework 🍄🆙improvement New feature or request labels Sep 3, 2025
@mfranzke mfranzke changed the title fix(tests): preventing test failure slipthrougs to main fix(tests): preventing test failure slip-througs to main Sep 3, 2025
@github-actions github-actions bot added 📺showcases Changes to 1-n showcases 🏘components labels Sep 3, 2025
@mfranzke mfranzke added postReview and removed 📺showcases Changes to 1-n showcases 🏘components labels Sep 3, 2025
@github-actions github-actions bot added 📺showcases Changes to 1-n showcases 🏘components labels Sep 3, 2025
@mfranzke mfranzke requested a review from sarahbrng as a code owner September 5, 2025 15:46
@mfranzke mfranzke moved this from 🏗 In development to 👀 In review in UX Engineering Team Backlog Sep 6, 2025
@mfranzke mfranzke removed their assignment Sep 6, 2025
@mfranzke mfranzke requested a review from Copilot September 6, 2025 09:02
@mfranzke mfranzke added this to the 3.1.0 milestone Sep 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses test failures that were passing in PR checks but failing on the main branch due to inconsistent test conditions between PR and main branch workflows. The changes fix select component value handling and temporarily disable conditional test execution to prevent false positives.

Key changes:

  • Fixed select component value handling by removing fallback empty string assignments
  • Temporarily disabled conditional test execution that was causing inconsistent results between PR and main branch

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
showcases/angular-showcase/src/app/components/select/select.component.html Removed fallback empty string for select value binding
packages/components/src/components/select/select.lite.tsx Removed selected attribute logic from placeholder option
packages/components/scripts/post-build/components.ts Added null coalescing operator for value handling in Angular implementation
.github/workflows/02-e2e-showcases.yml Commented out conditional test execution to ensure consistent test runs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mfranzke mfranzke merged commit 1335e51 into main Sep 6, 2025
54 checks passed
@mfranzke mfranzke deleted the fix-tests-preventing-test-failure-slipthrougs-to-main branch September 6, 2025 10:41
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢📀cicd Changes inside .github folder 🏘components 🍄🆙improvement New feature or request postReview 📺showcases Changes to 1-n showcases 🧪test Improvements/bugs for testing-framework

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants