Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thêm keyword để còn tra google =)) #6

Merged
merged 4 commits into from
Apr 16, 2016
Merged

Update thêm keyword để còn tra google =)) #6

merged 4 commits into from
Apr 16, 2016

Conversation

huyxgit
Copy link
Contributor

@huyxgit huyxgit commented Apr 16, 2016

No description provided.

@huyxgit
Copy link
Contributor Author

huyxgit commented Apr 16, 2016

english keywords for every section in this tutorials are necessary for beginners who need more resources from internet.

thangngoc89
thangngoc89 reviewed Apr 16, 2016
View reviewed changes
README.md
@@ -69,20 +69,22 @@ Khóa học này bao gồm 5 khóa học nhỏ

0.7 Biên dịch chương trình đầu tiên (Hello worrld)

#####Keyword: Biên dịch (compile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ở trên đang là heading 3 thì không thể dùng heading 5 đươc. Linter sẽ báo lỗi.

Mà Khoa nghĩ là nên dùng quote đi thì hợp lí hơn.

Keyword: Biên dịch (compile)

> Keyword: Biên dịch (compile)

@thangngoc89
Copy link
Contributor

LGTM

@letrandat
Copy link
Collaborator

LGTM

Thanks @minhhuy150894

@letrandat letrandat merged commit 130f3b6 into daynhauhoc:master Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huyxgit @thangngoc89 @letrandat