Solid wrapper #674
Merged
Solid wrapper #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjerleke
added
feature request
Closed
|
@LiamMartens I have a little left to test on this PR and I want to let you know that this is great! I will make some small adjustments to align some things with the other existing wrappers like React, Vue and Svelte. Soon Embla will have a SolidJS wrapper published 🎉. I want to put your name on the SolidJS wrapper if that’s ok? |
davidjerleke
force-pushed
the
feature/solid-support
branch
3 times, most recently
from
9a6e598 to
1d0ba4b
Compare
Co-authored-by: David Jerleke <david.jerleke@gmail.com> Co-authored-by: Liam Martens <hi@liammartens.com>
davidjerleke
force-pushed
the
feature/solid-support
branch
from
1d0ba4b to
32176d5
Compare
davidjerleke
approved these changes
Jan 6, 2024
|
Awesome thanks for having a look and merging! @davidjerleke |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a package for
Solid-JSsupport. Also includes docs for it.