Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for solid-js #429

Closed
oSethoum opened this issue Jan 29, 2023 · 4 comments · Fixed by #674
Closed

Support for solid-js #429

oSethoum opened this issue Jan 29, 2023 · 4 comments · Fixed by #674
Labels
feature request New feature or request resolved This issue is resolved solid Issue is related to SolidJS

Comments

@oSethoum
Copy link

oSethoum commented Jan 29, 2023

Can you support solid-js which has been gaining a lot of interest lately.

@oSethoum oSethoum added the feature request New feature or request label Jan 29, 2023
@davidjerleke
Copy link
Owner

davidjerleke commented Feb 10, 2023

Hi @oSethoum,

Thanks for your question. Let’s see if SolidJs devs are interested in this.

React with a —> 👍 if you want this feature.

@BoilingSoup
Copy link

BoilingSoup commented Mar 21, 2023

Hi just wanted to share that I was able to get Embla working very easily with Solid by following the vanilla JS steps.

Only thing I did different was add the JS code inside Solid's onMount() callback. Plugins are working perfectly too.

Here's a small demo:
https://stackblitz.com/edit/solidjs-templates-qznzud?file=src/App.tsx

@davidjerleke davidjerleke added the solid Issue is related to SolidJS label Nov 27, 2023
@davidjerleke davidjerleke linked a pull request Dec 31, 2023 that will close this issue
Repository owner deleted a comment from jassix Jan 1, 2024
davidjerleke pushed a commit to LiamMartens/embla-carousel that referenced this issue Jan 6, 2024
davidjerleke added a commit to LiamMartens/embla-carousel that referenced this issue Jan 6, 2024
Co-authored-by: David Jerleke <david.jerleke@gmail.com>
Co-authored-by: Liam Martens <hi@liammartens.com>
davidjerleke added a commit to LiamMartens/embla-carousel that referenced this issue Jan 6, 2024
Co-authored-by: David Jerleke <david.jerleke@gmail.com>
Co-authored-by: Liam Martens <hi@liammartens.com>
@davidjerleke
Copy link
Owner

Merged thanks to @LiamMartens great contribution. embla-carousel-solid will be released with v8.0.0-rc19 soon 🎉 !

@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 6, 2024
@davidjerleke
Copy link
Owner

davidjerleke commented Jan 7, 2024

@oSethoum, @aquaductape, @frozar, @ronaldruzicka, @Kies8, @ruijdacd, @RichardSPrins, @BoilingSoup, @flamrdevs, @StitiFatah, @jordant97, @dennisregalado, @alexnguyennz, @mikehwagz, @jamielaw-jellyfish, @its-monotype, @zaitsev1, @tobimori, @kielerdotdev, @ZorikovPasha, @itome, @VincentWENDLING, @dash-james, @pokedotdev, @ploskovytskyy, @jassix, @chemagares.


I just released the SolidJs wrapper with v8.0.0-rc19. Thanks a ton @LiamMartens ⭐!

Here's the get started guide.

There's still a lot to do. We need to add SolidJs code examples under all API pages. For example, here. Feel free to add these if you want to contribute.

Best,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request resolved This issue is resolved solid Issue is related to SolidJS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants