Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello first time trying out this package and I love everything about it but there's just one thing that's causing me some issues regarding the
slidesInView
event. I've created this Sandbox to demonstrate the issue.To reproduce:
I've added
engine.slidesInView.destroy()
in thedeactivate
function to fix the issue inembla-carousel
package.We can also listen to the
reinit
event to destroy the event but I feel like this shouldn't be done on the end user but on the package's side.