Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slidesInView memory leak - Not destroyed when carousel is dismantled #614

Closed
1 task done
Tracked by #321
davidjerleke opened this issue Nov 1, 2023 · 0 comments · Fixed by #613
Closed
1 task done
Tracked by #321

slidesInView memory leak - Not destroyed when carousel is dismantled #614

davidjerleke opened this issue Nov 1, 2023 · 0 comments · Fixed by #613
Labels
bug Something isn't working resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Nov 1, 2023

👉 Credit goes to @fcasibu.

Bug is related to

  • embla-carousel (core package)

Embla Carousel version

  • v8.0.0-rc14

Describe the bug

  • engine.slidesInView.destroy() should fire on these events: destroy and reInit.

CodeSandbox

  • The link to a CodeSandbox that demonstrates the bug clearly.

Steps to reproduce

  1. Try not to resize the sandbox and see the counter "called" gets incremented by 1 perfectly fine
  2. Resize the sandbox
  3. Wait for the autoplay to slide automatically or slide it yourself
  4. Counter "called" gets incremented by A LOT and this shouldn't happen

Expected behavior

  • engine.slidesInView.destroy() should fire on destroy, and reInit.
@davidjerleke davidjerleke added the bug Something isn't working label Nov 1, 2023
@davidjerleke davidjerleke linked a pull request Nov 1, 2023 that will close this issue
@davidjerleke davidjerleke mentioned this issue Nov 1, 2023
37 tasks
@davidjerleke davidjerleke added the resolved This issue is resolved label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant