Skip to content

Conversation

@Norbytus
Copy link
Contributor

@Norbytus Norbytus commented Apr 1, 2025

While impl interface registration, find error in proc macros php_impl
Is missing separator for quote

@Xenira
Copy link
Collaborator

Xenira commented Apr 2, 2025

@Norbytus thanks for catching this.

I'll check if I can add a simple test to catch this going forward.

@Norbytus
Copy link
Contributor Author

Norbytus commented Apr 2, 2025

@Norbytus thanks for catching this.

I'll check if I can add a simple test to catch this going forward.

I actually try little bit rewrite method generation. Cause it's make some problem to add interface registration.

I make pr later or not)

@Xenira Xenira changed the title fix: Add missing separator pipe in flags fix(macro): Add missing separator pipe in flags Apr 2, 2025
@Xenira
Copy link
Collaborator

Xenira commented Apr 2, 2025

I actually try little bit rewrite method generation. Cause it's make some problem to add interface registration.

I just did a big change on how the macros work (#372). Some bugs are expected and there are some things that can be done better. Thats why 0.14 is not released yet.

If you plan a bigger change, please create an issue first though. That way possible solutions can be discussed and you do not waste your time on something that is going in the wrong direction.

I make pr later or not)

Its usually better to create PRs as early as possible. That way you can get feedback earlier. Just mark it as draft to indicate that its not ready yet.

@Xenira Xenira merged commit 852bf4c into davidcole1340:master Apr 2, 2025
33 checks passed
@davidcole1340 davidcole1340 mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants