refactor(macro)!: change to builder pattern #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenira
force-pushed
the
macro-state-deprecation-v2
branch
from
c00a928 to
8bc33fb
Compare
This was
linked to
issues
Feb 20, 2025
|
Decided to go with builder pattern and move the outer macro back in priority. Would still like to have it, but there are some cases that really need a builder, so this is the foundation. |
Xenira
force-pushed
the
macro-state-deprecation-v2
branch
14 times, most recently
from
4253a65 to
f46ca0a
Compare
|
So this is a chonker... Most of it is taken from #174 which already had some review. I tried to rebase onto current master, but it was to old to get that done cleanly. I pulled what I could and integrated it with the new stuff and added stubs back in. |
migrate outdated builder to current version BREAKING CHANGE: The old macros were dependent on execution order and have been causing trouble with language servers. They are replaced by a builder. See the migration guide at https://davidcole1340.github.io/ext-php-rs/migration-guides/v0.14.html for information on how to migrate. Fixes: #99, #131, #327 Refs: #174, #335 Co-authored-by: David Cole <david.cole1340@gmail.com> Co-authored-by: Pierre Tondereau <ptondereau@users.noreply.github.com> Co-authored-by: Daniil Gentili <daniil@daniil.it>
Xenira
force-pushed
the
macro-state-deprecation-v2
branch
from
f46ca0a to
aeed538
Compare
joelwurtz
reviewed
Feb 28, 2025
Fixes: #337 Co-authored-by: Yoram <yoramdelangen@gmail.com>
Xenira
force-pushed
the
macro-state-deprecation-v2
branch
from
aeed538 to
6db05a4
Compare
joelwurtz
approved these changes
Mar 2, 2025
Xenira
force-pushed
the
macro-state-deprecation-v2
branch
2 times, most recently
from
91a1ae8 to
8060a79
Compare
Other solutions require unstable features
Xenira
force-pushed
the
macro-state-deprecation-v2
branch
from
8060a79 to
b6724f0
Compare
|
I'll just merge this now. Has been open long enough for comments. Lets just wait a bit longer before the next release to find issues. |
joehoyle
reviewed
Sep 9, 2025
| .parse_meta() | ||
| .map_err(|_| anyhow!("Unable to parse attribute."))?; | ||
| fn get_method_props<'a>(self) -> ::std::collections::HashMap<&'static str, ::ext_php_rs::props::Property<'a, #path>> { | ||
| todo!() |
There was a problem hiding this comment.
It looks like this was never fixed, so actually getters / setters don't work at all right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The old macros were dependent on execution order and have been causing trouble with language servers. They are replaced by a builder. See the migration guide at https://davidcole1340.github.io/ext-php-rs/migration-guides/v0.14.html for information on how to migrate.
Fixes: #99, #131, #327
Refs: #174, #335