UFAL/Fix: preserve namespace in OAI link rewrite on static pages (#1226)#1227
Merged
milanmajchrak merged 1 commit intodtq-devfrom Feb 27, 2026
Merged
UFAL/Fix: preserve namespace in OAI link rewrite on static pages (#1226)#1227milanmajchrak merged 1 commit intodtq-devfrom
milanmajchrak merged 1 commit intodtq-devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the static-page OAI hyperlink rewrite so it preserves any namespace prefix embedded in rest.baseUrl (e.g. /repository/server), matching the expected deployment routing.
Changes:
- Replace
new URL('/server/oai', restBase)with a trailing-slash-safe string append to preserverest.baseUrlpath prefixes. - Update and extend unit tests to cover namespace-prefixed
rest.baseUrland prevent double slashes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/app/static-page/static-page.component.ts |
Adjust OAI URL construction to keep the full rest.baseUrl path (including namespace prefixes). |
src/app/static-page/static-page.component.spec.ts |
Update existing test inputs and add a new test for namespace-prefixed rest.baseUrl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Fixes #1226
The OAI link rewrite in static pages used new URL('/server/oai', restBase) which discarded the namespace prefix (e.g. /repository) from rest.baseUrl. Replaced with direct string append so the full path is preserved.
Added test for namespace-prefixed baseUrl scenario.
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review