MENDELU/Fix security error unsafe resource url (NG0904)#1164
Merged
milanmajchrak merged 1 commit intocustomer/mendelufrom Dec 19, 2025
Merged
Conversation
…ng citaceProURL, adding null validation, and ensuring URL is sanitized before binding
Closed
There was a problem hiding this comment.
Pull request overview
This PR fixes the NG0904 unsafe resource URL error in the citation iframe component by ensuring proper initialization and sanitization of the citation URL.
- Initializes
citaceProURLproperty with explicitnullvalue and makes it public for template binding - Adds null validation checks in
makeCitaceProURLmethod before constructing URL - Removes unnecessary
iframeSrcgetter and binds directly tocitaceProURLin template
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/item-page/simple/field-components/specific-field/citation/item-page-citation.component.ts | Initializes citaceProURL with null, adds null validation in makeCitaceProURL method, and removes the redundant iframeSrc getter |
| src/app/item-page/simple/field-components/specific-field/citation/item-page-citation.component.html | Updates template condition to check citaceProURL existence and binds src directly to citaceProURL instead of iframeSrc |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
milanmajchrak
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Fix NG0904 unsafe resource URL error in citation iframe by initializing citaceProURL, adding null validation, and ensuring URL is sanitized before binding. Instead of using iframeSrc method, use citaceProURL instead.
... on localhost, run on dev mode, the message was:
ERROR RuntimeError: NG0904: unsafe value used in a resource URL context (see https://g.co/ng/security#xss) at ɵɵsanitizeResourceUrl (core.mjs:10232:11) at elementPropertyInternal (core.mjs:12606:37) at Module.ɵɵproperty (core.mjs:22504:9) at ItemPageCitationFieldComponent_Conditional_0_Template (item-page-citation.component.html:6:5)Copilot review