Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torchmetrics usage improvements with classes instead of functionals #517

Merged
merged 71 commits into from
Sep 10, 2024
Merged

Torchmetrics usage improvements with classes instead of functionals #517

merged 71 commits into from
Sep 10, 2024

Commits on Apr 26, 2024

  1. Removed ipu metrics, since not compatible with latest torchmetrics

    @DomInvivo
    DomInvivo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bd59098 View commit details
    Browse the repository at this point in the history

  2. Updated MetricWrapper to work with update and compute, compatib… 

    …le with `torchmetrics`
    @DomInvivo
    DomInvivo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    734ba55 View commit details
    Browse the repository at this point in the history

  3. Changed requirements for torchmetrics

    @DomInvivo
    DomInvivo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b6c578f View commit details
    Browse the repository at this point in the history

  4. fixed the loss by adding MetricToTorchMetrics, and added a few comm… 

    …ents on the `Predictor` for Todos
    @DomInvivo
    DomInvivo committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4f6e816 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Major updates to predictor_summaries.py

    @DomInvivo
    DomInvivo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7933ae5 View commit details
    Browse the repository at this point in the history

  2. Improved the predictor summaries. Added GradientNormMetric

    @DomInvivo
    DomInvivo committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5849927 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Improved the task summaries and started to fix the training logging.

    @DomInvivo
    DomInvivo committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f355eed View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Fixed test_metrics. Moved lots of spaces.py imports to inner functi… 

    …ons to avoid import loops
    @DomInvivo
    DomInvivo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4372ace View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. duplicated some unit-test fixes from graphium_3.0 branch

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7b89998 View commit details
    Browse the repository at this point in the history

  2. Fixed the loading of a previous dummy model using older metrics by re… 

    …moving the metrics from the model
    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ab88952 View commit details
    Browse the repository at this point in the history

  3. Minor documentation

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6c58733 View commit details
    Browse the repository at this point in the history

  4. Removed the loss from predictor_summaries

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    a9a8810 View commit details
    Browse the repository at this point in the history

  5. Removed epochs from task summaries

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2185697 View commit details
    Browse the repository at this point in the history

  6. Draft implementing the update/compute logic in the predictor.

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d37d818 View commit details
    Browse the repository at this point in the history

  7. Fix the std metric. Still needs testing.

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b4524f9 View commit details
    Browse the repository at this point in the history

  8. fixed all errors arising in test_finetuning.py

    @DomInvivo
    DomInvivo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5040c47 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fixed the test_training.py unit test

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e761e08 View commit details
    Browse the repository at this point in the history

  2. Standardized the test names

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5d60fbf View commit details
    Browse the repository at this point in the history

  3. Fixed some unit-tests that were broken by previous changes

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b59428a View commit details
    Browse the repository at this point in the history

  4. Added pytdc to the tests

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    632d4dc View commit details
    Browse the repository at this point in the history

  5. Changed mamba install tdc to pip install, in the test.yml file

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0fa2d86 View commit details
    Browse the repository at this point in the history

  6. Added '--no-deps' to TDC installation in test.yml

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2441f43 View commit details
    Browse the repository at this point in the history

  7. Woops

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    326b6e7 View commit details
    Browse the repository at this point in the history

  8. Fixed issue with building docs

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    641fa37 View commit details
    Browse the repository at this point in the history

  9. Removed old file from breaking docs building

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2b85dce View commit details
    Browse the repository at this point in the history

  10. Changed to micromamba to install pytdc

    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0c93a0f View commit details
    Browse the repository at this point in the history

  11. Added tests for the STDMetric and GradientNormMetric and fixed th… 

    …eir outputs
    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ec235fc View commit details
    Browse the repository at this point in the history

  12. Implemented test of MultiTaskSummaries. Only an error left for the me… 

    …an and std of preds and targets
    @DomInvivo
    DomInvivo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    38d03e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Fixed the preds and targets that were inverted in TaskSummary

    @DomInvivo
    DomInvivo committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    d6f62a4 View commit details
    Browse the repository at this point in the history

  2. Tried to add grad_norm to the metrics, but won't work because it's no… 

    …t per task
    @DomInvivo
    DomInvivo committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    3673884 View commit details
    Browse the repository at this point in the history

  3. Moved the gradient metric directly to the Predictor

    @DomInvivo
    DomInvivo committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    29598a2 View commit details
    Browse the repository at this point in the history

  4. Removed file_opener and read_file

    @DomInvivo
    DomInvivo committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    6260fa1 View commit details
    Browse the repository at this point in the history

  5. Fixed predictor grad_norm

    @DomInvivo
    DomInvivo committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    10a1017 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'graphium_3.0' into torchmetrics

    @DomInvivo
    DomInvivo authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8aa0f2b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Fixed the progress bar logging to newest version. Fixed minor issues … 

    …in the logging and imports.
    @DomInvivo
    DomInvivo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    90c0ca4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/torchmetrics' into torchmetrics

    @DomInvivo
    DomInvivo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    be99d94 View commit details
    Browse the repository at this point in the history

  3. fixed some issue with older version of torchmetrics

    @DomInvivo
    DomInvivo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    44b66b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Fixed reversed preds/targets. Fixed random sampling to take in the DF… 

    … idx. Few other minor changes
    @DomInvivo
    DomInvivo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5c421a6 View commit details
    Browse the repository at this point in the history

  2. fixed missing metrics computation on on_train_batch_end

    @DomInvivo
    DomInvivo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f15cd9a View commit details
    Browse the repository at this point in the history

  3. Added toymix training to the unit-tests. Also useful to run in debug … 

    …mode.
    @DomInvivo
    DomInvivo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2142313 View commit details
    Browse the repository at this point in the history

  4. Adding _global/ to some metrics logging into wandb

    @DomInvivo
    DomInvivo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    99e0cd6 View commit details
    Browse the repository at this point in the history

  5. Added better handling of metrics failure with logger.warn

    @DomInvivo
    DomInvivo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    045ea53 View commit details
    Browse the repository at this point in the history

  6. Fixed metric issues on gpu by casting to the right device prior to `.… 

    …update`
    @DomInvivo
    DomInvivo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d8ba606 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Added losses to the metrics, such that they are computed on val and t… 

    …est too
    @DomInvivo
    DomInvivo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1bf2734 View commit details
    Browse the repository at this point in the history

  2. Restricting the numpy version due to issues with wandb

    @DomInvivo
    DomInvivo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    68b9361 View commit details
    Browse the repository at this point in the history

  3. detaching preds

    @DomInvivo
    DomInvivo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    911dfe9 View commit details
    Browse the repository at this point in the history

  4. Removed cuda version restriction

    @DomInvivo
    DomInvivo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d34ac60 View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary detach, that broke the loss

    @DomInvivo
    DomInvivo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b1f2e86 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Minor gitignore

    @DomInvivo
    DomInvivo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9dbd021 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Fixed the error due to time metrics on CPU `No backend type associate… 

    …d with device type cpu`
    @DomInvivo
    DomInvivo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5a77cbe View commit details
    Browse the repository at this point in the history

  2. Added val epoch time

    @DomInvivo
    DomInvivo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7fba29d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Added logic to avoid crashing when resetting unused metrics

    @DomInvivo
    DomInvivo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    b59dc36 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Added MetricWrapper.device

    @DomInvivo
    DomInvivo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    da3e3a1 View commit details
    Browse the repository at this point in the history

  2. Disable caching model checkpoint through WandbLogger

    sft-managed committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8bf0d41 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Improved the testing of the metrics reset, update, compute

    @DomInvivo
    DomInvivo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    6f35ea9 View commit details
    Browse the repository at this point in the history

  2. Reverted wrong change in `train_finetune_test.py

    @DomInvivo
    DomInvivo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d2f84f2 View commit details
    Browse the repository at this point in the history

  3. Improved __len__ in MultitaskDataModule

    @DomInvivo
    DomInvivo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e9be441 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Added a new logic to allow saving all preds and targets more efficien… 

    …tly for auroc and avpr
    @DomInvivo
    DomInvivo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    eaf9077 View commit details
    Browse the repository at this point in the history

  2. Fixed the concatenation to work with and without DDP. Moved to CPU fo… 

    …r faster + less memory requirement
    @DomInvivo
    DomInvivo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5432531 View commit details
    Browse the repository at this point in the history

  3. Fixed the issue with memory leaks and devices.

    @DomInvivo
    DomInvivo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8c75d77 View commit details
    Browse the repository at this point in the history

  4. Fixed the CPU syncing of MetricToConcatenatedTorchMetrics and GPU f… 

    …or other metrics
    @DomInvivo
    DomInvivo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5abd769 View commit details
    Browse the repository at this point in the history

  5. Fixed the training metrics, and grouped all epoch-time and tput metrics

    @DomInvivo
    DomInvivo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fac3052 View commit details
    Browse the repository at this point in the history

  6. Fixed epoch_time tracking (because train ends after val)

    @DomInvivo
    DomInvivo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d0ed816 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Using the torchmetrics.Metric.sync instead of torch_distributed

    @DomInvivo
    DomInvivo committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9b7063f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Fixed issue that NaNs are always removed with mean-per-label

    @DomInvivo
    DomInvivo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    136b8b0 View commit details
    Browse the repository at this point in the history

  2. Changed the name of logging variables

    @DomInvivo
    DomInvivo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2724b4c View commit details
    Browse the repository at this point in the history

  3. Removed some IPU logic

    @DomInvivo
    DomInvivo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    141f48b View commit details
    Browse the repository at this point in the history

  4. Fixed the syncing of MetricToConcatenatedTorchMetrics

    @DomInvivo
    DomInvivo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    62f2224 View commit details
    Browse the repository at this point in the history

  5. Fixed classification metric calculation when multitask_handling=flatten

    @AnujaSomthankar
    AnujaSomthankar committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2b58fed View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Fixed all unit-test, except those for IPU

    @DomInvivo
    DomInvivo committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    2fb7f4b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'graphium_3.0' into torchmetrics

    @AnujaSomthankar
    AnujaSomthankar authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ce4f94d View commit details
    Browse the repository at this point in the history