-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Torchmetrics usage improvements with classes instead of functionals #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le with `torchmetrics`
…ents on the `Predictor` for Todos
4 tasks
…ons to avoid import loops
…moving the metrics from the model
DomInvivo
changed the title
Torchmetrics usage improvements
Torchmetrics usage improvements with classes instead of functionals
Jul 16, 2024
…d with device type cpu`
…tly for auroc and avpr
…r faster + less memory requirement
…or other metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
update
andcompute
to avoid memory issues with large validation setpredictor_summaries.py
to simply handle metrics updates and compute + new unit-testsMetricWrapper
SingleTaskSummary
andMultiTaskSummary
test_training.py
andtest_finetuning.py
to make sure that the full pipeline runsProgressBar
callback to fix the progress bar loggingtask
parameter.Checklist:
MetricWrapper
to work with the update/compute from torchmetrics #466feature
,fix
ortest
(or ask a maintainer to do it for you).discussion related to that PR