Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order atoms and edges when matching molecules from different datasets #502

Closed
wants to merge 15 commits into from

Conversation

DomInvivo
Copy link
Collaborator

@DomInvivo DomInvivo commented Jan 5, 2024

Changelogs

  • Find the canonical ordering of every molecule
  • Find a mapping between the order of the featurized molecule, and the molecule associated to the labels
  • Re-order the atoms for "node"-level tasks
  • Re-order the atoms for "edge"-level tasks
  • Re-order the atoms for "nodepair"-level tasks.

Checklist:

  • Closing Wrong ordering of nodes/edges in multitasking for node/edge level tasks #467
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

This PR is related to issue #467. It haven't been tested or run yet, it's still in draft mode. The idea is to re-order the labels for molecules that have been merged during the featurization, but for which ordering is important, such as node-level and edge-level tasks.

@DomInvivo DomInvivo added ASAP priority Major thing to do or fix fix PR that fixes an issue labels Jan 5, 2024
@DomInvivo DomInvivo self-assigned this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP priority Major thing to do or fix fix PR that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong ordering of nodes/edges in multitasking for node/edge level tasks
1 participant