Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ordering of nodes/edges in multitasking for node/edge level tasks #467

Closed
DomInvivo opened this issue Sep 20, 2023 · 0 comments · Fixed by #503 or #521
Closed

Wrong ordering of nodes/edges in multitasking for node/edge level tasks #467

DomInvivo opened this issue Sep 20, 2023 · 0 comments · Fixed by #503 or #521
Labels
bug Something isn't working

Comments

@DomInvivo
Copy link
Collaborator

I'll write more details later, but in MultitaskDataset.merge, it merges the molecules that are identical across datasets. But if the ordering of the nodes/edges/nodepairs are different, then nothing guarantees that the order will be the same, so the nodes that ends up being used might be in a different orders than the labels.

In that function, if there is a node/edge/nodepair task, all the labels must be re-ordered according to the ordering of the unique graph selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment