Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(React / Ember): React as the default UI #2252

Merged
merged 9 commits into from
Mar 18, 2021
Merged

refactor(React / Ember): React as the default UI #2252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a63e57c
Making React the Default Frontend
jjoyce0510 Mar 16, 2021
ecfcb74
EnableEmber instead of enableReact
jjoyce0510 Mar 18, 2021
acb9355
Minor doc fixes
jjoyce0510 Mar 18, 2021
20e91c3
Making React the Default Frontend
jjoyce0510 Mar 16, 2021
35b6fee
EnableEmber instead of enableReact
jjoyce0510 Mar 18, 2021
7746631
Minor doc fixes
jjoyce0510 Mar 18, 2021
09a5fea
Remove specific date
jjoyce0510 Mar 18, 2021
42c0dce
Removing date from doc
jjoyce0510 Mar 18, 2021
56fed09
Adjusting Social Badges
jjoyce0510 Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor doc fixes
  • Loading branch information
@jjoyce0510
jjoyce0510 committed Mar 18, 2021
commit 7746631452bb5ac5bfa4fa9b2176866e62a3a8d7
5 changes: 1 addition & 4 deletions datahub-frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ However, if you only want to build `DataHub Frontend` specifically:
```

### Building Ember App
To build datahub-frontend to serve the legacy React app, build with the additional "enableEmber" property:
To build datahub-frontend to serve the legacy Ember app, build with the additional "enableEmber" property:

```
./gradlew :datahub-frontend:build -PenableEmber=true
Expand Down Expand Up @@ -58,9 +58,6 @@ the application directly from command line after a successful [build](#build):
cd datahub-frontend/run && ./run-local-frontend
```

### Serving React App
If you are running the React app locally via `yarn start`, it will be forwarding graphql requests to port `9002`. In order to use `./run-local-frontend` with the React app, change the PORT value in [./run/frontend.env](./run/frontend.env) to `9002` and restart `./run-local-frontend`

## Checking out DataHub UI
After starting your application in one of the two ways mentioned above, you can connect to it by typing below
into your favorite web browser:
Expand Down
2 changes: 1 addition & 1 deletion datahub-frontend/run/frontend.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Server Port
PORT=9001
PORT=9002

# Secret Key
DATAHUB_SECRET="YouKnowNothing"
Expand Down