Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(React / Ember): React as the default UI #2252

Merged
merged 9 commits into from
Mar 18, 2021

Conversation

jjoyce0510
Copy link
Collaborator

Scope
This change affects folks using both React + Ember app.

Changes
This change swaps makes React the default UI and includes both code & documentation changes necessary to do so. Specific changes include

  • datahub-frontend-react in docker-compose.yml, remove legacy datahub-frontend container. This means quickstart will launch with React app on localhost:9002 by default.
  • Introduces docker-compose.ember.yml, an extension compose file containing the legacy ember container.
  • Introduces quickstart-ember.sh, removes quickstart-react.sh.
  • Doc updates to reflect legacy status of ember. '
  • Changed arguments to default to React in datahub-frontend/Dockerfile.
  • Swap "enableReact" gradle property to "enableEmber"

Validation
Locally built datahub-frontend-ember and datahub-frontend-react services.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 728a742 into datahub-project:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants