Added logic to fail test compilation if test SQL or expected SQL are empty#2082
Merged
Added logic to fail test compilation if test SQL or expected SQL are empty#2082
Conversation
fernst
requested review from
andrzej-grudzien,
ikholopov-omni and
kolina
and removed request for
a team and
andrzej-grudzien
ikholopov-omni
approved these changes
Feb 5, 2026
core/actions/test.ts
Outdated
| this.proto.expectedOutputQuery = testContext.apply(this.contextableQuery); | ||
|
|
||
| // Check if the test query and expected output query are non-empty. | ||
| if (this.proto.testQuery === null || this.proto.testQuery.trim() === "") { |
Collaborator
There was a problem hiding this comment.
You can !this.proto.testQuery to cover both null and undefined.
Same below
kolina
approved these changes
Feb 6, 2026
core/actions/test.ts
Outdated
| this.proto.expectedOutputQuery = testContext.apply(this.contextableQuery); | ||
|
|
||
| // Check if the test query and expected output query are non-empty. | ||
| if (!this.proto.testQuery || this.proto.testQuery.trim() === "") { |
Contributor
There was a problem hiding this comment.
!this.proto.testQuery.trim(), same below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.