Skip to content

Populate Discussion extra page #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Populate Discussion extra page #151

merged 2 commits into from
Jan 25, 2022

Conversation

tobyhodges
Copy link
Member

@tobyhodges tobyhodges commented Aug 18, 2021

Fixes #138 by adding a summary of the rationale behind the choices of image processing libary and image viewer used in the lesson to the Extras->Discussion page. If you think we should include a summary of any of the other points discussed during our co-working call last week, please post here and I can add them to this PR.

@quist00
Copy link
Contributor

quist00 commented Aug 18, 2021

I think it looks good, but I will wait on merge, in case other reviewers have insights on additional points to include.

@uschille
Copy link
Contributor

I also think it looks good, but we should test %matplotlib notebook on different platforms (as @quist00 pointed out on Slack it may not always work out-of-the box).

@uschille uschille added the status:wait Progress dependent on another issue or conversation label Sep 14, 2021
@uschille
Copy link
Contributor

uschille commented Oct 3, 2021

Pending update of setup instructions #164.

@bobturneruk bobturneruk self-assigned this Nov 12, 2021
@uschille uschille removed the status:wait Progress dependent on another issue or conversation label Dec 9, 2021
@tobyhodges tobyhodges merged commit 39dad3b into gh-pages Jan 25, 2022
@tobyhodges tobyhodges deleted the discussion-extra branch January 25, 2022 15:42
zkamvar pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate or remove Discussion extra page
4 participants