Skip to content

feat(core): Add ability to specify chart version in diff #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(core): Add ability to specify chart version in diff #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"fmt"
"os"
"strings"

"github.com/spf13/cobra"
"k8s.io/helm/pkg/helm"
Expand All @@ -11,7 +12,7 @@ import (
)

const globalUsage = `
Show a diff explaing what a helm upgrade would change.
Show a diff explaining what a helm upgrade would change.

This fetches the currently deployed version of a release
and compares it to a local chart plus values.
Expand All @@ -24,6 +25,7 @@ var Version string = "HEAD"
type diffCmd struct {
release string
chart string
version string
// out io.Writer
client helm.Interface
// version int32
Expand All @@ -36,7 +38,7 @@ func main() {
diff := diffCmd{}

cmd := &cobra.Command{
Use: "diff [flags] [RELEASE] [CHART]",
Use: "diff [flags] [RELEASE] [CHART]@[CHART VERSION]",
Short: "Show manifest differences",
Long: globalUsage,
RunE: func(cmd *cobra.Command, args []string) error {
Expand All @@ -50,6 +52,14 @@ func main() {

diff.release = args[0]
diff.chart = args[1]
diff.version = ""

if strings.Contains(args[1], "@") {
s := strings.Split(args[1], "@")
diff.chart = s[0]
diff.version = s[1]
}

if diff.client == nil {
diff.client = helm.NewClient(helm.Host(os.Getenv("TILLER_HOST")))
}
Expand All @@ -68,7 +78,7 @@ func main() {
}

func (d *diffCmd) run() error {
chartPath, err := locateChartPath(d.chart, "", false, "")
chartPath, err := locateChartPath(d.chart, d.version, false, "")
if err != nil {
return err
}
Expand Down