feat(core): Add ability to specify chart version in diff #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'm currently on vacation until next week and will take a look ASAP. |
|
Sorry for letting this slide. The reason I'm hesitant to merge this is #6 which asks for diffs between revisions of a release. I'm still trying to come up with a nice CLI interface to allow to unambiguously specify a local chart directory, chart with version or release revision for both positional arguments ( |
|
+1 for diff between revisions. |
Closed
|
I believe this has been fixed by a536dfc and is shipped since version 2.9.0+1 of this plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
This is useful if you don't always want to use the latest chart in your diff. Allows user ability to specify chart version to diff against.
Changes