Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I can specify a date format for the data I'm providing #5

Closed
marta- opened this issue Oct 14, 2020 · 0 comments
Closed

As a user, I can specify a date format for the data I'm providing #5

marta- opened this issue Oct 14, 2020 · 0 comments
Assignees

Comments

@marta-
Copy link
Contributor

marta- commented Oct 14, 2020

Most of the time, users will paste patient information from a spreadsheet into the the form for generating GUIDs. The origin data may contain dates in a different format.

Under the PII input, display a dropdown labeled "Date format for the dates of birth", hint "Please specify the format of the dates of birth by selecting one of the supported formats", with 12 values (expand the expressions to specify different separators):

  • yyyy[-/. ]MM[-/. ]dd, E.g. 2010-12-23,
  • dd[-/. ]MM[-/. ]yyyy, E.g. 23-12-2010,
  • MM[-/. ]dd[-/. ]yyyy, E.g. 12-23-2010.

yyyy-MM-dd should be selected by default.

Dates should be validated against the selected format (update the regexp from #3 to match each entry).

Additionally, update the regexps to ensure that single digit day and month are accepted (e.g. 2010-1-17).

@marta- marta- changed the title As a user, I can specify a date format for the data i'm providing As a user, I can specify a date format for the data I'm providing Oct 14, 2020
veronikaslc pushed a commit that referenced this issue Oct 15, 2020
…viding

Fixed bug with wrong error message
Added calendar icon"
veronikaslc pushed a commit that referenced this issue Oct 15, 2020
marta- added a commit that referenced this issue Oct 15, 2020
…viding

{UI} Adjusted the position of the calendar icon
marta- added a commit that referenced this issue Oct 16, 2020
…viding

* Reorganized the code to separate date processing functionality
* Updated helper texts to reflect currently selected date format
* Fixed bug where different date formats would generate different GUIDs forthe same date because of wrong date serialization before hashing
@marta- marta- closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants