Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion continuous_integration/scripts/test_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def main(argv: list[str] | None = None) -> None:
total.groupby([total.file, total.test])
.filter(lambda g: (g.status == "x").sum() >= args.nfails)
.reset_index()
.assign(test=lambda df: df.file + "." + df.test)
.assign(test=lambda df: df.file + "." + df.test) # type: ignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

df.file is type Any and it's not easy to cast this within a lambda so just ignoring it.

.groupby("test")
)
overall = {name: grouped.get_group(name) for name in grouped.groups}
Expand Down
1 change: 1 addition & 0 deletions distributed/worker_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ def memory_monitor(self, nanny: Nanny) -> None:
except (ProcessLookupError, psutil.NoSuchProcess, psutil.AccessDenied):
return # pragma: nocover

assert self.memory_limit
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.memory_limit should be set by this point as it's used on the next line in a division, so asserting it to make mypy happy that it's not None.

if memory / self.memory_limit <= self.memory_terminate_fraction:
return

Expand Down
Loading