Skip to content

Conversation

@jacobtomlinson
Copy link
Member

Looks like mypy is failing on main. This PR fixes up those small issues.

.filter(lambda g: (g.status == "x").sum() >= args.nfails)
.reset_index()
.assign(test=lambda df: df.file + "." + df.test)
.assign(test=lambda df: df.file + "." + df.test) # type: ignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

df.file is type Any and it's not easy to cast this within a lambda so just ignoring it.

except (ProcessLookupError, psutil.NoSuchProcess, psutil.AccessDenied):
return # pragma: nocover

assert self.memory_limit
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.memory_limit should be set by this point as it's used on the next line in a division, so asserting it to make mypy happy that it's not None.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 44m 15s ⏱️ - 10m 30s
 4 112 tests ±0   4 004 ✅ ±0    104 💤 ±0  3 ❌  - 1  1 🔥 +1 
51 517 runs  +1  49 329 ✅ +1  2 184 💤 ±0  3 ❌  - 1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit fac040f. ± Comparison against base commit 1a1953d.

@jacobtomlinson
Copy link
Member Author

Test failures appear unrelated. Given these are just some small typing tweaks I'm going to merge.

@jacobtomlinson jacobtomlinson merged commit 54a7352 into dask:main Dec 9, 2025
29 of 34 checks passed
@jacobtomlinson jacobtomlinson deleted the typing-fixes branch December 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant