Skip to content

Conversation

@crusaderky
Copy link
Collaborator

Closes #6582
Of course, an exceptionally slow VM could print out "Creating scratch directories is taking a surprisingly long time" five times in a row - we'll iterate again if it happens.

@crusaderky crusaderky force-pushed the quiet_close_process branch from eea3ebf to 4c01945 Compare August 25, 2022 11:15
Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A different approach could be to change the client script to

import warnings
from dask.distributed import Client
allowed_warnings = [
    ...
]
if __name__ == "__main__":
    for msg in allowed_warnings:
        warnings.filterwarings("ignore", msg)
    client = Client(processes=%s, n_workers=1, scheduler_port=0, dashboard_address=":0")

I'm OK either way

@crusaderky
Copy link
Collaborator Author

@fjetter my approach however has the advantage that, if the spurious warnings start cropping up every time, the test will fail.

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  +       1         15 suites  +1   6h 43m 29s ⏱️ + 1h 5m 2s
  3 044 tests ±       0    2 957 ✔️ +     12    84 💤  - 11  3  - 1 
22 514 runs  +1 819  21 536 ✔️ +1 807  975 💤 +13  3  - 1 

For more details on these failures, see this check.

Results for commit 4c01945. ± Comparison against base commit b8d1c7b.

@fjetter fjetter merged commit 31cd316 into dask:main Aug 25, 2022
@crusaderky crusaderky deleted the quiet_close_process branch August 25, 2022 13:56
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test_quiet_close_process[False]

2 participants