lazily get dask version information #5822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
reviewed
Feb 16, 2022
Contributor
graingert
force-pushed
the
faster-dunder-version
branch
from
02941db to
7d445d4
Compare
fjetter
reviewed
Feb 17, 2022
graingert
force-pushed
the
faster-dunder-version
branch
from
7d445d4 to
b1c6b0d
Compare
Member
|
Your file formatting is a bit off. I would suggest to install pre-commit, see http://distributed.dask.org/en/stable/develop.html#code-formatting |
graingert
force-pushed
the
faster-dunder-version
branch
from
b1c6b0d to
3578e4c
Compare
this uses "importlib.metadata:version" - for __version__ which is much faster than git
graingert
force-pushed
the
faster-dunder-version
branch
from
3578e4c to
8947abd
Compare
fjetter
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses "importlib.metadata:version" - for version which is much faster than git
gitsubprocesses in CI (when installed with -e) #5700pre-commit run --all-files