Replace versioneer with setuptools-scm #9137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
commented
Nov 4, 2025
| "get_client", | ||
| "get_task_metadata", | ||
| "get_task_stream", | ||
| "get_versions", |
Member
Author
There was a problem hiding this comment.
Technically this is breaking, but this internal versioneer method was never intended to be exposed publicly anyway. If anyone is depending on this they should probably switch to __version__ or importlib.metadata.version("distributed").
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 9h 42m 32s ⏱️ +56s For more details on these failures, see this check. Results for commit b578cf6. ± Comparison against base commit a9ad6d4. ♻️ This comment has been updated with latest results. |
4 tasks
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/distributed
that referenced
this pull request
Nov 15, 2025
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/distributed
that referenced
this pull request
Nov 17, 2025
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/distributed
that referenced
this pull request
Nov 19, 2025
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/distributed
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
setuptools-scmis more widely used and better maintained thanversioneer(last release was July 2023) we might want to switch.pyproject.tomlto usesetuptools-scmdistributed/_version.pyfile assetuptools-scmgenerates this during sdist/wheel build (orpip install -e .)setup.py__getattr__shim added in lazily get dask version information #5822.setuptools-scmimplementation of_version.pyshould be much faster than the wayversioneerwas generating from git every import so it's better to simplify thingsxref dask/dask#12133