Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flake8 #93

Merged
merged 32 commits into from
Feb 2, 2019
Merged

Use flake8 #93

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
d902ea4
Require flake8 be installed on CI
jakirkham Feb 2, 2019
6957732
Require `flake8` and `pytest-flake8` for testing
jakirkham Feb 2, 2019
60f052d
Ensure flake8 is run with pytest
jakirkham Feb 2, 2019
165ba06
Exclude versioneer and docs from flake8
jakirkham Feb 2, 2019
cfd913c
Drop unused external imports caught by flake8
jakirkham Feb 2, 2019
221a813
Wrap long warning line
jakirkham Feb 2, 2019
7550d71
Break up warning string across multiple lines
jakirkham Feb 2, 2019
bc51d97
Drop some internal unused imports
jakirkham Feb 2, 2019
ff51bdc
Avoid flake8 unused import error
jakirkham Feb 2, 2019
fce0376
Reorder imports in ndfilters
jakirkham Feb 2, 2019
579a709
Ignore `lambda` assignment with flake8
jakirkham Feb 2, 2019
a0d4cb5
Adjust line wrapping of `lambda`
jakirkham Feb 2, 2019
3277a00
Disable the flake8 lambda assignment on both lines
jakirkham Feb 2, 2019
d4b2478
Drop flake8 noqa from second `lambda` line
jakirkham Feb 2, 2019
c4bc4dd
Remove whitespace before `:` for flake8
jakirkham Feb 2, 2019
a78024b
Have flake8 ignore `lambda` assignment
jakirkham Feb 2, 2019
9a922fe
Wrap parameterized arguments
jakirkham Feb 2, 2019
727df5e
Wrap test parameterized arguments
jakirkham Feb 2, 2019
efce8ac
Ignore `lambda` assignment with flake8
jakirkham Feb 2, 2019
c333600
Wrap parameterized arguments
jakirkham Feb 2, 2019
4526740
Wrap parameterized arguments
jakirkham Feb 2, 2019
53f6bc6
Ignore `lambda` assignment with flake8
jakirkham Feb 2, 2019
c85f741
Trim whitespace before `:` in `lambda` for flake8
jakirkham Feb 2, 2019
8cdcb4d
Ignore `lambda` assignment with flake8
jakirkham Feb 2, 2019
2d0ffca
Drop extra blank line
jakirkham Feb 2, 2019
d17122c
Compare `str`s with `==`s instead of `is`
jakirkham Feb 2, 2019
94737d2
Drop unused import
jakirkham Feb 2, 2019
5c1c680
Allow a couple of long lines
jakirkham Feb 2, 2019
b917c5a
Require flake8 and pytest plugin on Python 3.5
jakirkham Feb 2, 2019
b78e404
Switch to `[tool:pytest]` in `setup.cfg`
jakirkham Feb 2, 2019
b854202
Cleanup SciPy check in `test_fourier_filter_type`
jakirkham Feb 2, 2019
161b423
Cleanup SciPy check in `test_measure_props`
jakirkham Feb 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore lambda assignment with flake8 
We are not really interested in flake8's `lambda` assignment rule in
these cases. So simply tell flake8 to ignore these lines.
  • Loading branch information
@jakirkham
jakirkham committed Feb 2, 2019
commit 8cdcb4d7d4e4e6eb937e50d7b5ac36737e28ea8f
4 changes: 2 additions & 2 deletions tests/test_dask_image/test_ndfilters/test__utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@


def test__get_docstring():
f = lambda: 0
f = lambda: 0 # noqa: E731

result = _utils._get_docstring(f)

Expand All @@ -37,7 +37,7 @@ def test__get_docstring():


def test__update_wrapper():
f = lambda: 0
f = lambda: 0 # noqa: E731

@_utils._update_wrapper(f)
def g():
Expand Down