Use flake8 #93

jakirkham · 2019-02-02T06:14:04Z

Updates the test suite to use flake8 to lint the code as part of the pytest run. Also fixes several errors caught by running flake8.

As the tests make use of flake8 (specifically a pytest plugin for flake8), require `flake8` and `pytest-flake8`.

Uses the flake8 plugin for pytest to ensure that flake8 checks are run as part of pytest.

These imports were probably used for code that no longer needs them. So go ahead and drop these unused imports.

Running flake8 picked out this line as too long. This wraps it some to try and fix this issue.

To fit the 79 character limit constraint, split this warning into two strings on two lines that are concatenated.

Some internal imports are unused according to flake8. So we drop them here to fix these flake8 errors.

To workaround flake8 unused import errors where we know these functions are imported and used elsewhere, go ahead and perform trivial assignments to make use of these functions. This still passes the tests and removes the flake8 errors.

Make sure that all imports in `ndfilters` happen before other statements to fix flake8 errors.

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

Removes the need for the `\`, which seems to be causing issues with `flake8`.

For some reason disabling this flake8 error on the second line is not sufficient. So disable it on the first lines as well.

This `noqa` seems to have no effect. So just drop it to avoid having these in excess.

As flake8 complains the line length is too long here, wrap these arguments to fit them within the recommended line length.

To fit the recommended line length, wrap the test function's parameterized arguments.

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

As flake8 complains the line length is too long here, wrap these arguments to fit them within the recommended line length.

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

As the `operator` module is not being used in this test module, drop it from the imports.

These are a little annoying to wrap currently. So simply tell flake8 to not worry about these.

As Python 3.5 is not supported in conda-forge any more, this uses the slightly older versions of packages that work with Python 3.5 in order to run the flake8 tests there as well.

As the `[pytest]` section in `setup.cfg` seems to be deprecated and raises errors when used with newer pytest versions, switch to using `[tool:pytest]` instead. This seems to work ok even with old versions of pytest used with Python 3.5.

As flake8 did not like how this line was formatted, we simplify it a bit and adjust the indentation to make it happier.

jakirkham added 30 commits February 2, 2019 14:50

Require flake8 be installed on CI

d902ea4

Require flake8 and pytest-flake8 for testing

6957732

As the tests make use of flake8 (specifically a pytest plugin for flake8), require `flake8` and `pytest-flake8`.

Ensure flake8 is run with pytest

60f052d

Uses the flake8 plugin for pytest to ensure that flake8 checks are run as part of pytest.

Exclude versioneer and docs from flake8

165ba06

Drop unused external imports caught by flake8

cfd913c

These imports were probably used for code that no longer needs them. So go ahead and drop these unused imports.

Wrap long warning line

221a813

Running flake8 picked out this line as too long. This wraps it some to try and fix this issue.

Break up warning string across multiple lines

7550d71

To fit the 79 character limit constraint, split this warning into two strings on two lines that are concatenated.

Drop some internal unused imports

bc51d97

Some internal imports are unused according to flake8. So we drop them here to fix these flake8 errors.

Avoid flake8 unused import error

ff51bdc

To workaround flake8 unused import errors where we know these functions are imported and used elsewhere, go ahead and perform trivial assignments to make use of these functions. This still passes the tests and removes the flake8 errors.

Reorder imports in ndfilters

fce0376

Make sure that all imports in `ndfilters` happen before other statements to fix flake8 errors.

Ignore lambda assignment with flake8

579a709

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

Adjust line wrapping of lambda

a0d4cb5

Removes the need for the `\`, which seems to be causing issues with `flake8`.

Disable the flake8 lambda assignment on both lines

3277a00

For some reason disabling this flake8 error on the second line is not sufficient. So disable it on the first lines as well.

Drop flake8 noqa from second lambda line

d4b2478

This `noqa` seems to have no effect. So just drop it to avoid having these in excess.

Remove whitespace before : for flake8

c4bc4dd

Have flake8 ignore lambda assignment

a78024b

Wrap parameterized arguments

9a922fe

As flake8 complains the line length is too long here, wrap these arguments to fit them within the recommended line length.

Wrap test parameterized arguments

727df5e

To fit the recommended line length, wrap the test function's parameterized arguments.

Ignore lambda assignment with flake8

efce8ac

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

Wrap parameterized arguments

c333600

As flake8 complains the line length is too long here, wrap these arguments to fit them within the recommended line length.

Wrap parameterized arguments

4526740

As flake8 complains the line length is too long here, wrap these arguments to fit them within the recommended line length.

Ignore lambda assignment with flake8

53f6bc6

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

Trim whitespace before : in lambda for flake8

c85f741

Ignore lambda assignment with flake8

8cdcb4d

We are not really interested in flake8's `lambda` assignment rule in these cases. So simply tell flake8 to ignore these lines.

Drop extra blank line

2d0ffca

Compare strs with ==s instead of is

d17122c

Drop unused import

94737d2

As the `operator` module is not being used in this test module, drop it from the imports.

Allow a couple of long lines

5c1c680

These are a little annoying to wrap currently. So simply tell flake8 to not worry about these.

Require flake8 and pytest plugin on Python 3.5

b917c5a

As Python 3.5 is not supported in conda-forge any more, this uses the slightly older versions of packages that work with Python 3.5 in order to run the flake8 tests there as well.

Switch to [tool:pytest] in setup.cfg

b78e404

As the `[pytest]` section in `setup.cfg` seems to be deprecated and raises errors when used with newer pytest versions, switch to using `[tool:pytest]` instead. This seems to work ok even with old versions of pytest used with Python 3.5.

jakirkham added 2 commits February 2, 2019 17:43

Cleanup SciPy check in test_fourier_filter_type

b854202

As flake8 did not like how this line was formatted, we simplify it a bit and adjust the indentation to make it happier.

Cleanup SciPy check in test_measure_props

161b423

As flake8 did not like how this line was formatted, we simplify it a bit and adjust the indentation to make it happier.

jakirkham merged commit d5bac99 into dask:master Feb 2, 2019

jakirkham deleted the use_flake8 branch February 2, 2019 07:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use flake8 #93

Use flake8 #93

jakirkham commented Feb 2, 2019

Use flake8 #93

Use flake8 #93

Conversation

jakirkham commented Feb 2, 2019