Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style cleanup #227

Merged
merged 12 commits into from
May 24, 2021
Merged

Conversation

GenevieveBuckley
Copy link
Collaborator

@GenevieveBuckley GenevieveBuckley commented May 17, 2021

Closes #226
Also addresses most of the points in #101 (except for moving the function definitions out of the __init__.py files)

In this PR, I have:

  • Removed any from __future__ imports
  • Ran isort on all the files in the repository
  • Removed the assert dask statements from the top of several test modules. (I believe they are superfluous, because if dask is not available there will be an ImportError while pytest is collecting tests, so I don't think we'll ever reach that line anyway? If I'm wrong and they're in for a reason, let me know and I'll reverse this change)
  • Code style cleanup: Always use import numpy as np
  • Code style cleanup: Always use import dask.array as da
  • Code style cleanup: Always use import scipy.ndimage
  • Code style cleanup: For clarity, use import dask_image.ndfilters instead of import dask_image.ndfilters as da_ndf
  • Code style cleanup: flake8 formatting

@GenevieveBuckley
Copy link
Collaborator Author

If the CI checks all pass, I'll merge this.

@GenevieveBuckley GenevieveBuckley merged commit aeff4d1 into dask:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop remaining Python 3isms
2 participants