Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Dask version and remove try/except imports #232

Closed
GenevieveBuckley opened this issue May 21, 2021 · 1 comment · Fixed by #286
Closed

Increase minimum Dask version and remove try/except imports #232

GenevieveBuckley opened this issue May 21, 2021 · 1 comment · Fixed by #286
Labels
good first issue Good for newcomers

Comments

@GenevieveBuckley
Copy link
Collaborator

We have this try/except statement for imports here:

try:
from dask.array import blockwise as da_blockwise
except ImportError:
from dask.array import atop as da_blockwise

According to John:

Yeah this was renamed in Dask 1.1.0 ( dask/dask#4348 ). If we are comfortable making that a minimum requirement, we can drop that and just use dask.array.blockwise below

Originally posted by @jakirkham in #227 (comment)

Reply from Gen:

I suspect that changing the minimum requirement for Dask is going to involve some fiddling with the environment files we use for the CI, so I'll open an issue & that can be a separate PR.

@GenevieveBuckley
Copy link
Collaborator Author

Thank you @jakirkham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants