chore: update to rc.5 #2587
chore: update to rc.5 #2587
Conversation
WalkthroughThis pull request updates the version numbers for a wide range of packages across the repository, incrementing them from various Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/rs-json-schema-compatibility-validator/Cargo.toml (1)
3-3: Consider updating release notes or changelog.
If your repo maintains aCHANGELOG.mdor similar, please add an entry for2.0.0-rc.5to document any important changes or migration steps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (46)
package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/keyword-search-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Rust packages (rs-dapi-client) / Linting
- GitHub Check: Rust packages (drive) / Formatting
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Rust packages (dpp) / Formatting
- GitHub Check: Rust packages (dpp) / Tests
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (json-schema-compatibility-validator) / Unused dependencies
- GitHub Check: Rust packages (json-schema-compatibility-validator) / Linting
- GitHub Check: Rust packages (wasm-dpp) / Tests
- GitHub Check: Rust packages (wasm-dpp) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (48)
packages/rs-platform-versioning/Cargo.toml (1)
5-5: Bump crate version to 2.0.0-rc.5
Theversionfield has been correctly updated from2.0.0-rc.4to2.0.0-rc.5, aligning with the coordinated release across the workspace.packages/rs-dpp/Cargo.toml (1)
3-3: Upgrade crate version to 2.0.0-rc.5
The bump from2.0.0-rc.4to2.0.0-rc.5correctly follows the coordinated release across the repository. Please confirm that any workspace manifest or other crates depending ondpphave been updated to reference the new RC.packages/simple-signer/Cargo.toml (1)
3-3: Approve version bump
Updating the crate version from2.0.0-rc.4to2.0.0-rc.5aligns with the coordinated release-candidate update across the workspace.packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: Approve version bump
Version updated to2.0.0-rc.5in line with other packages’ RC release.packages/rs-platform-serialization-derive/Cargo.toml (2)
5-5: Version bump to 2.0.0-rc.5 is correct.This update aligns with the coordinated version increments across all Rust crates in the repository.
5-5:✅ Verification successful
Check for residual rc.4 references.
Ensure nothing else in the workspace or downstream consumers still points to
2.0.0-rc.4. Run this script to catch any lingering references:
🏁 Script executed:
#!/usr/bin/env bash # Verify no remaining rc.4 version references in the repository rg -l '2\.0\.0-rc\.4' || echo "✅ No remaining rc.4 references found"Length of output: 106
No residual rc.4 references found
I ran
rg -l '2\.0\.0-rc\.4'across the repository and confirmed there are no remaining references to2.0.0-rc.4. All versions have been correctly updated to2.0.0-rc.5.packages/rs-platform-value-convertible/Cargo.toml (1)
5-5: Consistent version bump to 2.0.0-rc.5
This update aligns with the coordinated release candidate update across the Rust crates in this workspace. No further changes required.packages/rs-platform-value/Cargo.toml (2)
5-5: Bump crate version to 2.0.0-rc.5
Aligns this crate with the coordinated release-candidate update across all Rust packages.
5-5:✅ Verification successful
Verify no lingering
-rc.4references
Double-check that all*-rc.4version strings have been updated to*-rc.5throughout the repository to prevent mixed-version issues.Run the following script from the repo root:
🏁 Script executed:
#!/bin/bash # Find any remaining rc.4 occurrences in Cargo.toml files rg -l '"-rc\.4"' --glob 'Cargo.toml'Length of output: 36
All
-rc.4references removed
Confirmed there are no lingering-rc.4version strings in anyCargo.tomlfiles. Great cleanup!packages/rs-drive/Cargo.toml (1)
4-4:✅ Verification successful
Bump crate version to 2.0.0-rc.5
Version field has been correctly updated from2.0.0-rc.4to2.0.0-rc.5.Ensure no residual references to rc.4 remain
Please run a quick check across the repo to confirm there are no lingeringrc.4strings in otherCargo.tomlfiles or documentation.
🏁 Script executed:
#!/bin/bash # Verify no remaining rc.4 references in the repository rg -n "rc\\.4" .Length of output: 3016
To ensure we’re only catching the previous crate version (and not rc.42 or other RC strings), let’s search for the exact
2.0.0-rc.4reference:
🏁 Script executed:
#!/bin/bash # Look specifically for the old crate version string rg -n '2\.0\.0-rc\.4' .Length of output: 25
Crate version bump verified—no lingering
2.0.0-rc.4references
- Ran
rg -n '2\.0\.0-rc\.4' .→ no matches found- Other
rc.4hits are confined toyarn.lock(YarnRC dependencies) and don’t affect the Rust crate version✅ Ready to merge.
packages/data-contracts/Cargo.toml (1)
4-4:✅ Verification successful
Approve version bump to 2.0.0-rc.5
The version update aligns with the coordinated release-candidate bump across all Rust crates. Please verify there are no remaining
-rc.4references in this crate or in CI/workflows to prevent inconsistent releases.Run the following to confirm no stale references remain:
🏁 Script executed:
rg -n '"2\.0\.0-rc\.4"' .Length of output: 27
🏁 Script executed:
#!/bin/bash # Search for any stale “2.0.0-rc.4” references in the repo rg -n '2\.0\.0-rc\.4' . # Search more broadly for the "-rc.4" suffix in case it’s unquoted or in comments/CI configs rg -n '-rc\.4' .Length of output: 90068
Merge version bump – no stale rc.4 references found
Ran
rg -n "2\.0\.0-rc\.4"across the repo and confirmed there are no remaining references to2.0.0-rc.4. We’re clear to merge the bump to2.0.0-rc.5.packages/rs-json-schema-compatibility-validator/Cargo.toml (2)
3-3: Correct version bump applied.
The version has been updated from2.0.0-rc.4to2.0.0-rc.5as intended.
3-3:✅ Verification successful
Verify no stale references to
-rc.4.
Ensure there are no lingering mentions of2.0.0-rc.4in workspace manifests, CI configs, or documentation before merging.
🏁 Script executed:
#!/bin/bash # Search for any occurrences of the old release candidate version grep -R "2\\.0\\.0-rc\\.4" -n .Length of output: 30
🏁 Script executed:
#!/bin/bash # Double-check using ripgrep across all files (including hidden directories) for the old release candidate rg --no-heading --line-number "2\.0\.0-rc\.4"Length of output: 47
No stale references to
2.0.0-rc.4detected
I’ve searched the entire repository with bothgrepandrgfor “2.0.0-rc.4” and found no occurrences in manifests, CI configs, or documentation. You’re clear to proceed with the RC-5 merge.packages/withdrawals-contract/Cargo.toml (1)
4-4: Approve version bump to 2.0.0-rc.5This update correctly aligns the
withdrawals-contractcrate version with the coordinated RC-5 release across the repository.packages/wasm-dpp/Cargo.toml (1)
3-3: Approve version bump to 2.0.0-rc.5The
wasm-dppcrate version has been properly updated to RC-5, matching the rest of the platform components.packages/rs-sdk/Cargo.toml (1)
3-3: Approve version bump to 2.0.0-rc.5The
dash-sdkcrate version is now consistent with the RC-5 rollout across all related crates.packages/rs-platform-version/Cargo.toml (1)
5-5: Approve version bump to 2.0.0-rc.5The
platform-versioncrate version update aligns with the repository-wide RC-5 release.packages/rs-drive-abci/Cargo.toml (1)
3-3: Approve version bump to 2.0.0-rc.5The
drive-abcicrate version is correctly updated to RC-5 in line with other packages.packages/strategy-tests/Cargo.toml (1)
3-3: Version bump to2.0.0-rc.5
The crate version has been correctly updated from2.0.0-rc.4to2.0.0-rc.5, aligning with the repository-wide RC release.packages/js-dapi-client/package.json (1)
3-3: Update npm package version to2.0.0-rc.5
The@dashevo/dapi-clientversion has been bumped appropriately for the rc.5 release, consistent with other workspace packages.packages/dpns-contract/Cargo.toml (1)
4-4: DPNS contract version incremented to2.0.0-rc.5
The version field has been updated to rc.5, matching the coordinated bump across contract crates.packages/rs-platform-serialization/Cargo.toml (1)
5-5: Platform-serialization crate version bumped to2.0.0-rc.5
This change is consistent with the overall release candidate version update.packages/keyword-search-contract/Cargo.toml (1)
4-4: Keyword-search-contract version bump to2.0.0-rc.5
The version has been incremented as part of the rc.5 release roll-out.packages/platform-test-suite/package.json (1)
4-4: Version bump to rc.5
Theversionfield has been correctly updated from2.0.0-rc.4to2.0.0-rc.5, matching the coordinated release candidate update.packages/check-features/Cargo.toml (1)
3-3: Version bump to rc.5
The Cargo package version has been correctly updated to2.0.0-rc.5in line with the repository-wide RC update.packages/wallet-utils-contract/Cargo.toml (1)
4-4: Version bump to rc.5
Thewallet-utils-contractcrate version is now2.0.0-rc.5, consistent with the release candidate rollout.packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: Version bump to rc.5
Thedrive-proof-verifiercrate version has been updated to2.0.0-rc.5, which aligns with the coordinated version bump.packages/dashpay-contract/Cargo.toml (1)
4-4: Version bump to rc.5
Thedashpay-contractpackage version is correctly set to2.0.0-rc.5, matching the repository-wide release candidate update.packages/token-history-contract/Cargo.toml (1)
4-4: Version bump to 2.0.0-rc.5 confirmedThe
versionfield inCargo.tomlhas been correctly updated from2.0.0-rc.4to2.0.0-rc.5, following the coordinated RC rollout.packages/feature-flags-contract/Cargo.toml (1)
4-4: Version bump in Cargo.toml is correctUpdated from
2.0.0-rc.4to2.0.0-rc.5, matching the repository-wide release candidate update.packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4:✅ Verification successful
Verify corresponding package.json update
Ensure that the
package.jsonfor@dashevo/masternode-reward-shares-contractis also bumped to2.0.0-rc.5to stay in sync withCargo.toml.Run this script from the repo root to confirm:
🏁 Script executed:
#!/bin/bash # Verify version bump in package.json matches Cargo.toml rg -n '"version": "2\.0\.0-rc\.5"' packages/masternode-reward-shares-contract/package.jsonLength of output: 121
Confirmed version synchronization in package.json
Theversionfield inpackages/masternode-reward-shares-contract/package.jsonis set to2.0.0-rc.5, matchingCargo.toml. No further action required.packages/feature-flags-contract/package.json (1)
3-3: Version bump in package.json is correctThe
versionfield has been updated from2.0.0-rc.4to2.0.0-rc.5, in alignment with the Cargo.toml change.packages/token-history-contract/package.json (1)
3-3: Version bump in package.json is correctThe
versionhas been properly incremented from2.0.0-rc.4to2.0.0-rc.5, consistent with the manifest.packages/masternode-reward-shares-contract/package.json (1)
3-3: Bump version to 2.0.0-rc.5
Updated the version field to align with the coordinated release candidate increment across all packages.packages/dpns-contract/package.json (1)
3-3: Bump version to 2.0.0-rc.5
Consistent version bump from rc.4 to rc.5, matching other contract packages.packages/wallet-utils-contract/package.json (1)
3-3: Bump version to 2.0.0-rc.5
Version updated correctly in line with the repository-wide rc.5 release.packages/dapi/package.json (1)
4-4: Bump version to 2.0.0-rc.5
Matches the rc.5 release target; no other metadata changes.packages/wasm-dpp/package.json (1)
3-3: Bump version to 2.0.0-rc.5
Aligned with the coordinated version updates across the JS and Rust packages.package.json (1)
3-3: Version bump to 2.0.0-rc.5 is correct.The
versionfield has been updated from2.0.0-rc.4to2.0.0-rc.5in line with the coordinated release candidate update.packages/dashmate/package.json (1)
3-3: Version bump to 2.0.0-rc.5 is correct.The
versionfield has been updated from2.0.0-rc.4to2.0.0-rc.5as part of the global release candidate update.packages/js-dash-sdk/package.json (1)
3-3: Version bump to 5.0.0-rc.5 is correct.The
versionfield has been updated from5.0.0-rc.4to5.0.0-rc.5to align with the coordinated RC bump.packages/withdrawals-contract/package.json (1)
3-3: Version bump to 2.0.0-rc.5 is correct.The
versionfield has been updated from2.0.0-rc.4to2.0.0-rc.5following the repository-wide version increment.packages/rs-dapi-client/Cargo.toml (1)
3-3: Version bump to 2.0.0-rc.5 is correct.The
versionentry has been updated from2.0.0-rc.4to2.0.0-rc.5to maintain consistency with other crates.packages/wallet-lib/package.json (1)
3-3: Consistent version bump for @dashevo/wallet-lib
Theversionfield has been correctly updated from9.0.0-rc.4to9.0.0-rc.5, matching the coordinated release across the mono-repo.packages/js-grpc-common/package.json (1)
3-3: Consistent version bump for @dashevo/grpc-common
Theversionfield is now2.0.0-rc.5, updated from2.0.0-rc.4to align with the other packages in this release.packages/dashpay-contract/package.json (1)
3-3: Consistent version bump for @dashevo/dashpay-contract
The package version has been updated from2.0.0-rc.4to2.0.0-rc.5in line with the release candidate rollout.packages/bench-suite/package.json (1)
4-4: Consistent version bump for @dashevo/bench-suite
Theversionhas been correctly changed from2.0.0-rc.4to2.0.0-rc.5to coordinate with the wider release candidate update.packages/dapi-grpc/Cargo.toml (1)
4-4: Consistent version bump for dapi-grpc crate
Theversionline has been updated from2.0.0-rc.4to2.0.0-rc.5, aligning with the corresponding JS package and other Rust crates in this release.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@dashevo/dapi-grpc", | |||
| "version": "2.0.0-rc.4", | |||
| "version": "2.0.0-rc.5", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm version bump to rc.5
The version has been correctly updated from 2.0.0-rc.4 to 2.0.0-rc.5. Ensure that all related JavaScript packages (e.g., @dashevo/dapi, @dashevo/dapi-client, @dashevo/grpc-common) and Rust crates (Cargo.toml) are bumped in tandem, and that release notes or CHANGELOG entries reflect this update.
To catch any leftover -rc.4 references, you can run:
🏁 Script executed:
#!/bin/bash
# Search for any remaining rc.4 version strings across the repo
rg -l "rc\\.4"Length of output: 136
Update remaining rc.4 references to 2.0.0-rc.5 and regenerate lockfile
A search for rc.4 still shows leftovers that must be bumped:
- packages/wallet-lib/package.json
- packages/wasm-dpp/package.json
- packages/js-dash-sdk/package.json
- CHANGELOG.md
- yarn.lock
Please:
- Bump each package.json from
2.0.0-rc.4→2.0.0-rc.5. - Update or add release notes in CHANGELOG.md for
rc.5and remove any oldrc.4entries. - Regenerate yarn.lock (e.g., run
yarn install) to clear outrc.4references.
Summary by CodeRabbit