fix: 6853 follow-up

[UdjinM6]

Issue being fixed or feature implemented

b11d4e1 (#6853) broke styling in SendCoinsDialog (all text is smaller now).

develop (using CJ tx as an example to make most of text visible)

before b11d4e1 (#6853)

What was done?

Fixed styling and also fixed some typos while at it. It looks like this now.

How Has This Been Tested?

Run dash-qt and try sending regular and CJ txes to one/many recipients.

Breaking Changes

n/a

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[coderabbitai]

Walkthrough

• Added a persistent HTML span wrapping around the full confirmation/question text block to unify styling (opening tag at start, closing tag at end).
• Inserted a leading space before the “Learn more” anchor in the coin-join warning line.
• Updated PSBT-related strings: replaced “Partially Signed Bitcoin Transaction (PSBT)” with “Partially Signed Blockchain Transaction (PSBT)” in two messages, keeping structure otherwise unchanged.
• No changes to logic, control flow, or return values; edits are limited to string content and HTML markup within sendcoinsdialog.cpp.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “fix: 6853 follow-up” directly references the related issue and indicates a follow-up fix to PR #6853, so it is clearly tied to the changeset even though it does not explicitly describe the specific styling corrections in SendCoinsDialog.
Description Check	✅ Passed	The description details the styling regression caused by commit b11d4e1, explains the restoration of styling in SendCoinsDialog along with typo fixes, includes before-and-after screenshots, and outlines testing steps, so it is fully relevant to the changeset.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54e2588 and 2f27744.

📒 Files selected for processing (1)

• src/qt/sendcoinsdialog.cpp (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/**/*.{cpp,h,cc,cxx,hpp}

📄 CodeRabbit inference engine (CLAUDE.md)

src/**/*.{cpp,h,cc,cxx,hpp}: Dash Core C++ codebase must be written in C++20 and require at least Clang 16 or GCC 11.1
Dash uses unordered_lru_cache for efficient caching with LRU eviction

Files:

• src/qt/sendcoinsdialog.cpp

🧬 Code graph analysis (1)

src/qt/sendcoinsdialog.cpp (1)

src/qt/guiutil.cpp (2)

• getThemedStyleQString (203-207)
• getThemedStyleQString (203-203)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: linux64_multiprocess-build / Build source
• GitHub Check: linux64_tsan-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: win64-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: linux64_fuzz-build / Build source

🔇 Additional comments (6)

src/qt/sendcoinsdialog.cpp (6)

365-366: LGTM!

The opening span tag correctly establishes a consistent styling wrapper for the entire confirmation text block, addressing the styling regression mentioned in the PR objectives where text appeared smaller after the previous commit.

---

379-379: LGTM!

The terminology update from "Bitcoin Transaction" to "Blockchain Transaction" is appropriate for the Dash Core codebase and maintains consistency with the project's branding.

---

384-384: LGTM!

Consistent terminology update matching line 379, correctly replacing Bitcoin-specific language with blockchain-appropriate terminology.

---

389-389: LGTM!

This closing tag correctly terminates the inner font-size:10pt span opened at line 371, maintaining proper HTML nesting.

---

447-447: LGTM!

The leading space before the anchor tag improves readability by providing proper separation between the warning text and the "Learn more" link.

---

469-470: LGTM!

The closing tag correctly terminates the global styling span opened at line 365-366, ensuring the entire confirmation text block has consistent styling and completing the fix for the styling regression.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[knst]

utACK 2f27744

[kwvg]

utACK 2f27744